Re: [RFC PATCH 0/8] block: fix bio_add_XXX_page() return type

[Johannes Thumshirn <Johannes.Thumshirn@wdc.com>]

On 20/05/2021 08:23, Chaitanya Kulkarni wrote:
> Hi,                                                                                 
> 
> The helper functions bio_add_XXX_page() returns the length which is
> unsigned int but the return type of those functions is defined
> as int instead of unsigned int.
> 
> This is an attempt to fix the return type of those functions
> and few callers. There are many places where this fix is needed
> in the callers, if this series makes it to the upstream I'll convert
> those callers gradually.
> 
> Any feedback is welcome.
> 
> -ck
> 
> Chaitanya Kulkarni (8):
>   block: fix return type of bio_add_hw_page()
>   block: fix return type of bio_add_pc_page()
>   block: fix return type of bio_add_zone_append_page
>   block: fix return type of bio_add_page()
>   lightnvm: fix variable type pblk-core
>   pscsi: fix variable type pscsi_map_sg
>   btrfs: fix variable type in btrfs_bio_add_page
>   block: fix variable type for zero pages
> 
>  block/bio.c                        | 20 +++++++++++---------
>  block/blk-lib.c                    |  2 +-
>  block/blk.h                        |  7 ++++---
>  drivers/lightnvm/pblk-core.c       |  3 ++-
>  drivers/target/target_core_pscsi.c |  6 ++++--
>  fs/btrfs/extent_io.c               |  2 +-
>  include/linux/bio.h                | 11 ++++++-----
>  7 files changed, 29 insertions(+), 22 deletions(-)
> 

I couldn't spot any errors, but I'm not sure it's worth the effort.

If Jens decides to take it:
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>