From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dipen Patel <dipenp@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
robh+dt@kernel.org, timestamp@lists.linux.dev,
krzysztof.kozlowski+dt@linaro.org, brgl@bgdev.pl, corbet@lwn.net,
gregkh@linuxfoundation.org
Subject: Re: [PATCH V4 02/10] dt-bindings: timestamp: Add Tegra234 support
Date: Sat, 25 Mar 2023 12:06:03 +0100 [thread overview]
Message-ID: <b1d365f8-8ed8-3fe4-0feb-176d90eeccac@linaro.org> (raw)
In-Reply-To: <20230323012929.10815-3-dipenp@nvidia.com>
On 23/03/2023 02:29, Dipen Patel wrote:
> Added timestamp provider support for the Tegra234 in devicetree
> bindings.
>
> Signed-off-by: Dipen Patel <dipenp@nvidia.com>
> ---
> v2:
> - Removed nvidia,slices property
> - Added nvidia,gpio-controller based on review comments from Thierry,
> this will help simplify the hte provider driver.
>
> v3:
> - Explained changes in detail in commit message
> - Added allOf section per review comment
>
> v4:
> - Logically divide the v3 patch as follows
> - Created Tegra234 support patch
> - Created depracate nvidia,slices property patch
> - Created addition of the nvidia,gpio-controller property patch
>
> .../timestamp/nvidia,tegra194-hte.yaml | 44 +++++++++++++++++--
> 1 file changed, 40 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
> index c31e207d1652..158dbe58c49f 100644
> --- a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
> +++ b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
> @@ -4,7 +4,7 @@
> $id: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Tegra194 on chip generic hardware timestamping engine (HTE)
> +title: Tegra on chip generic hardware timestamping engine (HTE) provider
>
> maintainers:
> - Dipen Patel <dipenp@nvidia.com>
> @@ -23,6 +23,8 @@ properties:
> enum:
> - nvidia,tegra194-gte-aon
> - nvidia,tegra194-gte-lic
> + - nvidia,tegra234-gte-aon
> + - nvidia,tegra234-gte-lic
>
> reg:
> maxItems: 1
> @@ -43,9 +45,8 @@ properties:
> description:
> HTE lines are arranged in 32 bit slice where each bit represents different
> line/signal that it can enable/configure for the timestamp. It is u32
> - property and depends on the HTE instance in the chip. The value 3 is for
> - GPIO GTE and 11 for IRQ GTE.
> - enum: [3, 11]
> + property and the value depends on the HTE instance in the chip.
> + enum: [3, 11, 17]
>
> '#timestamp-cells':
> description:
> @@ -55,6 +56,41 @@ properties:
> mentioned in the nvidia GPIO device tree binding document.
> const: 1
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - nvidia,tegra194-gte-aon
> + - nvidia,tegra234-gte-aon
> + then:
> + properties:
> + nvidia,slices:
> + const: 3
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - nvidia,tegra194-gte-lic
> + then:
> + properties:
> + nvidia,slices:
> + const: 11
> +
... and looking at your next patch - unreviewed...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-25 11:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 1:29 [PATCH V4 00/10] Add Tegra234 HTE support Dipen Patel
2023-03-23 1:29 ` [PATCH V4 01/10] MAINTAINERS: Add HTE/timestamp subsystem details Dipen Patel
2023-03-23 1:29 ` [PATCH V4 02/10] dt-bindings: timestamp: Add Tegra234 support Dipen Patel
2023-03-25 11:04 ` Krzysztof Kozlowski
2023-03-25 11:06 ` Krzysztof Kozlowski [this message]
2023-03-23 1:29 ` [PATCH V4 03/10] dt-bindings: timestamp: Deprecate nvidia,slices property Dipen Patel
2023-03-23 8:34 ` Linus Walleij
2023-03-25 11:05 ` Krzysztof Kozlowski
2023-04-03 18:49 ` Dipen Patel
2023-03-23 1:29 ` [PATCH V4 04/10] dt-bindings: timestamp: Add nvidia,gpio-controller Dipen Patel
2023-03-23 8:36 ` Linus Walleij
2023-03-23 13:58 ` Rob Herring
2023-03-24 17:13 ` Rob Herring
2023-03-24 18:51 ` Dipen Patel
2023-03-25 11:09 ` Krzysztof Kozlowski
2023-04-04 4:24 ` Dipen Patel
2023-04-04 5:33 ` Krzysztof Kozlowski
2023-04-04 17:31 ` Dipen Patel
2023-04-04 10:28 ` Thierry Reding
2023-04-04 17:30 ` Dipen Patel
2023-03-25 11:07 ` Krzysztof Kozlowski
2023-03-27 16:58 ` Dipen Patel
2023-04-04 10:30 ` Thierry Reding
2023-04-04 17:20 ` Dipen Patel
2023-03-23 1:29 ` [PATCH V4 05/10] arm64: tegra: Add Tegra234 GTE nodes Dipen Patel
2023-03-23 1:29 ` [PATCH V4 06/10] hte: Re-phrase tegra API document Dipen Patel
2023-04-05 2:24 ` Bagas Sanjaya
2023-04-06 0:03 ` Dipen Patel
2023-03-23 1:29 ` [PATCH V4 07/10] hte: Add Tegra234 provider Dipen Patel
2023-03-23 1:29 ` [PATCH V4 08/10] hte: Deprecate nvidia,slices property Dipen Patel
2023-03-23 1:29 ` [PATCH V4 09/10] hte: handle nvidia,gpio-controller property Dipen Patel
2023-03-23 8:37 ` Linus Walleij
2023-03-23 1:29 ` [PATCH V4 10/10] gpio: tegra186: Add Tegra234 hte support Dipen Patel
2023-03-23 8:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1d365f8-8ed8-3fe4-0feb-176d90eeccac@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dipenp@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).