From: Konstantin Ryabitsev <konstantin.ryabitsev@linux.dev>
To: Paul Barker <paul@pbarker.dev>, tools@linux.kernel.org
Cc: Konstantin Ryabitsev <konstantin.ryabitsev@linux.dev>
Subject: Re: [patatt][PATCH] Make instructions for automatic signing more reliable
Date: Mon, 31 May 2021 11:12:46 -0400 [thread overview]
Message-ID: <162247394427.416221.3988513350302949062.b4-ty@linux.dev> (raw)
In-Reply-To: <20210530163623.926-1-paul@pbarker.dev>
On Sun, 30 May 2021 17:36:23 +0100, Paul Barker wrote:
> We can't assume that the git directory path is '.git' from the root of
> the source tree. For example, this is not the correct path if patatt is
> checked out as a git submodule. We should use `git rev-parse --git-dir`
> to reliably determine the git directory path. We should also surround
> the path in quotes in case the user has cloned patatt in a path
> containing spaces.
Applied, thanks!
[1/1] Make instructions for automatic signing more reliable
commit: 1fc7ed529fc07036072b79c040f083b1db1c668a
Best regards,
--
Konstantin Ryabitsev <konstantin.ryabitsev@linux.dev>
prev parent reply other threads:[~2021-05-31 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 16:36 [patatt][PATCH] Make instructions for automatic signing more reliable Paul Barker
2021-05-31 15:12 ` Konstantin Ryabitsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162247394427.416221.3988513350302949062.b4-ty@linux.dev \
--to=konstantin.ryabitsev@linux.dev \
--cc=paul@pbarker.dev \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).