tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix cache aging cleanup of threads
@ 2021-06-01 20:08 Rob Herring
  2021-06-01 20:13 ` Konstantin Ryabitsev
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2021-06-01 20:08 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools, users

The cache aging for threads was not running resulting in failures to
fetch new messages in threads. Fix the empty cache check which should
be for no '.msgs' directories.

Fixes: 4950093c0c3e ("Don't use mboxo for anything")
Signed-off-by: Rob Herring <robh@kernel.org>
---
 b4/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/b4/__init__.py b/b4/__init__.py
index e16ebe6c8a37..c0ff004eb88d 100644
--- a/b4/__init__.py
+++ b/b4/__init__.py
@@ -1882,7 +1882,7 @@ def get_cache_dir(appname: str = 'b4') -> str:
         expmin = 600
     expage = time.time() - expmin
     for entry in os.listdir(cachedir):
-        if entry.find('.mbx') <= 0 and entry.find('.lookup') <= 0 and entry.find('.msgs'):
+        if entry.find('.mbx') <= 0 and entry.find('.lookup') <= 0 and entry.find('.msgs') <= 0:
             continue
         fullpath = os.path.join(cachedir, entry)
         st = os.stat(fullpath)
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix cache aging cleanup of threads
  2021-06-01 20:08 [PATCH] Fix cache aging cleanup of threads Rob Herring
@ 2021-06-01 20:13 ` Konstantin Ryabitsev
  0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Ryabitsev @ 2021-06-01 20:13 UTC (permalink / raw)
  To: Rob Herring; +Cc: Konstantin Ryabitsev, users, tools

On Tue, 1 Jun 2021 15:08:35 -0500, Rob Herring wrote:
> The cache aging for threads was not running resulting in failures to
> fetch new messages in threads. Fix the empty cache check which should
> be for no '.msgs' directories.

Ugh, thanks for finding that. Applied to both master and stable-0.7.y.
This is bad enough to roll a 0.7.1 soon.

[1/1] Fix cache aging cleanup of threads
      commit: b29c92d3e0a74024ce30c2eaf0cd6f9c5ca1fae9

Best regards,
-- 
Konstantin Ryabitsev <konstantin@linuxfoundation.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-01 20:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 20:08 [PATCH] Fix cache aging cleanup of threads Rob Herring
2021-06-01 20:13 ` Konstantin Ryabitsev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).