From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: tools@linux.kernel.org, Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH] ty: Fix git-config regexp in get_branch_info()
Date: Fri, 10 Mar 2023 15:11:22 -0500 [thread overview]
Message-ID: <167847908263.178358.3973742670339656772.b4-ty@linuxfoundation.org> (raw)
In-Reply-To: <20230310055753.1609529-1-mpe@ellerman.id.au>
On Fri, 10 Mar 2023 16:57:53 +1100, Michael Ellerman wrote:
> The regexp used to get the branch configuration in get_branch_info()
> is subtly wrong. If there are multiple branches starting with the same
> prefix, the configuration for all of them will be returned, which can
> lead to the wrong branch info being used.
>
> eg. Running b4 -d ty, with extra logging of every line in
> get_config_from_git() shows:
>
> [...]
Applied, thanks!
[1/1] ty: Fix git-config regexp in get_branch_info()
commit: 4f90eab09937e78f27e63a01076af72f8d45e3f3
Best regards,
--
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
prev parent reply other threads:[~2023-03-10 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 5:57 [PATCH] ty: Fix git-config regexp in get_branch_info() Michael Ellerman
2023-03-10 20:11 ` Konstantin Ryabitsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167847908263.178358.3973742670339656772.b4-ty@linuxfoundation.org \
--to=konstantin@linuxfoundation.org \
--cc=mpe@ellerman.id.au \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).