From: "Konstantin Ryabitsev" <konstantin@linuxfoundation.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: tools@linux.kernel.org, users@linux.kernel.org
Subject: Re: [kernel.org users] b4 version 0.3.5 released
Date: Fri, 27 Mar 2020 13:46:39 -0400 [thread overview]
Message-ID: <20200327174639.3an72wofl6tlfgjn@chatter.i7.local> (raw)
In-Reply-To: <yq1a741bt2b.fsf@oracle.com>
On Fri, Mar 27, 2020 at 01:34:20PM -0400, Martin K. Petersen wrote:
>
> Hi Konstantin!
>
> > Version 0.3.5 is a minor point release in the stable-0.3.y branch.
>
> I started noticing this a few commits back. Sometimes my SoB is being
> added before the patch author's. The interesting thing is that it is
> non-deterministic. I.e. if I run exactly the same b4 command several
> times in a row, sometimes the ordering is correct, sometimes it's
> reversed.
Dang it, I know why this is happening. I switched to using a set()
instead of a list() when handling trailers in order to simplify
duplicate tracking. Unfortunately, I forgot that the order in a set() is
non-deterministic, so even if we sort the list first, the moment it
becomes a set, we lose positioning information.
I'll put in a fix.
-K
next prev parent reply other threads:[~2020-03-27 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 16:45 b4 version 0.3.5 released Konstantin Ryabitsev
2020-03-27 17:34 ` [kernel.org users] " Martin K. Petersen
2020-03-27 17:46 ` Konstantin Ryabitsev [this message]
[not found] ` <16003A554CE54555.17905@linux.kernel.org>
2020-03-27 18:04 ` [tools] " Konstantin Ryabitsev
2020-03-27 20:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327174639.3an72wofl6tlfgjn@chatter.i7.local \
--to=konstantin@linuxfoundation.org \
--cc=martin.petersen@oracle.com \
--cc=tools@linux.kernel.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).