tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Konstantin Ryabitsev" <konstantin@linuxfoundation.org>
To: tools@linux.kernel.org
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	users@linux.kernel.org
Subject: Re: [tools] b4 v0.4.0 available with new features
Date: Tue, 28 Apr 2020 11:16:56 -0400	[thread overview]
Message-ID: <20200428151656.5qz5yiclxmffcnga@chatter.i7.local> (raw)
In-Reply-To: <yq11ro89x54.fsf@oracle.com>

On Mon, Apr 27, 2020 at 10:12:07PM -0400, Martin K. Petersen wrote:
> Second issue:
> 
> I have had a few cases today where my merge edits meant that b4 ty
> couldn't match the original patch-id up with a commit in my tree.
> 
> I can see the patches in question with b4 ty --list but b4 ty -s N
> fails because no match can be found. It would be nice to have a way to
> specify a commit hash and have b4 still write a .thanks file even when
> the patch-id matching fails. Something like:
> 
> $ b4 ty -s 10 -c <SHA>
> 
> would produce the thank you note with <SHA> as the ${summary} commit
> link.
> 
> It would also be great for the matching to be more forgiving (capturing
> per-patch message-id and matching with Link: tag, for instance). But I
> still think I might end up in situations where I would like to be able
> to force a thank you note given a ty id number and a commit hash.

Interesting -- did you modify the subjects of those commits as well?  
We're already falling back to matching by subject when we can't find 
exact patch-id matches.

How about we create a .thanks file even if no match is found (when used 
with -s, not --auto), except the summary will omit the commit-id 
information. You can then add that information manually or just send 
without it. After all, if you know for sure that you've applied that 
patch, then we shouldn't be stopping you from notifying the submitter 
about it.

So:

b4 ty -s 1,2,3

will always generate a .thanks file for those series, and will omit 
comit-id information when not found.

Does that sound okay?

-K

  reply	other threads:[~2020-04-28 15:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 17:04 b4 v0.4.0 available with new features Konstantin Ryabitsev
2020-04-24 23:35 ` [tools] " Martin K. Petersen
2020-04-27 18:40   ` Konstantin Ryabitsev
2020-04-28  2:12     ` Martin K. Petersen
2020-04-28 15:16       ` Konstantin Ryabitsev [this message]
2020-04-29  3:25         ` Martin K. Petersen
2020-04-28 16:03       ` [kernel.org users] " Jason Gunthorpe
2020-05-04 17:09 ` [kernel.org users] " Rob Herring
2020-05-04 17:17   ` Jason Gunthorpe
2020-05-04 20:09     ` Konstantin Ryabitsev
2020-05-04 23:07       ` Jason Gunthorpe
2020-05-04 20:03   ` Konstantin Ryabitsev
2020-05-04 22:58     ` Jason Gunthorpe
2020-05-04 23:04     ` Rob Herring
2020-05-06 19:23 ` Rob Herring
2020-05-07 20:20   ` Konstantin Ryabitsev
2020-05-12 19:07     ` Rob Herring
2020-06-09 22:24       ` Rob Herring
2020-07-27 14:52         ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200428151656.5qz5yiclxmffcnga@chatter.i7.local \
    --to=konstantin@linuxfoundation.org \
    --cc=martin.petersen@oracle.com \
    --cc=tools@linux.kernel.org \
    --cc=users@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).