From: "Jason Gunthorpe" <jgg@ziepe.ca>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Rob Herring <robh@kernel.org>,
users@linux.kernel.org, tools@linux.kernel.org
Subject: Re: [kernel.org users] b4 v0.4.0 available with new features
Date: Mon, 4 May 2020 20:07:21 -0300 [thread overview]
Message-ID: <20200504230721.GC26002@ziepe.ca> (raw)
In-Reply-To: <20200504200915.6yb6mo2rdcn6xjqg@chatter.i7.local>
On Mon, May 04, 2020 at 04:09:15PM -0400, Konstantin Ryabitsev wrote:
> On Mon, May 04, 2020 at 02:17:58PM -0300, Jason Gunthorpe wrote:
> > > I worry that automatically fixing it silently will create yet
> > > another
> > > case of tribal knowledge of maintainer practices/requirements for
> > > submitters. Maintainer A using b4 doesn't care if tags are added, but
> > > Maintainer B does care and gets grumpy. We need the tooling to promote
> > > that submitters should add these tags as that is what works in either
> > > case. It would be useful if b4 provided just the check as a separate
> > > command/option for integrating into maintainers tools or maybe
> > > submitter tools like checkpatch.pl.
> >
> > It would be helpful if b4 had a submitter focused command that would
> > sync the tags from the mailing list with the current series in git (or
> > whatever)
>
> Something like "auto-amend committed series with any newer
> trailers"?
Yes.
> the net result Maintainers are subtle and quick to anger, so
> I'm not sure I'm confident enough with my git skills to start rewriting
> history. :)
Ah! I have something for this:
https://github.com/jgunthorpe/Kernel-Maintainer-Tools/blob/master/gj_tools/cmd_gerrit.py#L98
It directly rewrites history, specifically the commit message ..
> I think providing a Link: tag is sufficient in this case anyway. Even if
> some trailers were sent to the list after a series was committed, the
> record of that trailer still exists, just external to the git repo.
Many maintainers will be unhappy if someone submits v2 of a series and
does not carry forwards the tags from v1.
Jason
next prev parent reply other threads:[~2020-05-04 23:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 17:04 b4 v0.4.0 available with new features Konstantin Ryabitsev
2020-04-24 23:35 ` [tools] " Martin K. Petersen
2020-04-27 18:40 ` Konstantin Ryabitsev
2020-04-28 2:12 ` Martin K. Petersen
2020-04-28 15:16 ` Konstantin Ryabitsev
2020-04-29 3:25 ` Martin K. Petersen
2020-04-28 16:03 ` [kernel.org users] " Jason Gunthorpe
2020-05-04 17:09 ` [kernel.org users] " Rob Herring
2020-05-04 17:17 ` Jason Gunthorpe
2020-05-04 20:09 ` Konstantin Ryabitsev
2020-05-04 23:07 ` Jason Gunthorpe [this message]
2020-05-04 20:03 ` Konstantin Ryabitsev
2020-05-04 22:58 ` Jason Gunthorpe
2020-05-04 23:04 ` Rob Herring
2020-05-06 19:23 ` Rob Herring
2020-05-07 20:20 ` Konstantin Ryabitsev
2020-05-12 19:07 ` Rob Herring
2020-06-09 22:24 ` Rob Herring
2020-07-27 14:52 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504230721.GC26002@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=konstantin@linuxfoundation.org \
--cc=robh@kernel.org \
--cc=tools@linux.kernel.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).