Linux maintainer tooling and workflows
 help / color / Atom feed
* b4 seems to be dropping "cc: stable" on patches.
@ 2020-10-19  7:20 Greg KH
  2020-10-19 12:43 ` Konstantin Ryabitsev
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-10-19  7:20 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: users, tools, Johan Hovold, Sasha Levin

Hi Konstantin,

It looks like 'b4' is dropping the cc: stable lines of patches.

Or at least it currently does this for me when I do the following:

$ b4 am -t https://lore.kernel.org/r/20200921135951.24045-3-johan@kernel.org
Looking up https://lore.kernel.org/r/20200921135951.24045-3-johan%40kernel.org
Grabbing thread from lore.kernel.org/linux-usb
Analyzing 22 messages in the thread
---
Writing ./v2_20200921_johan_usb_cdc_acm_handle_broken_union_descriptors.mbx
  [PATCH v2 1/4] Revert "cdc-acm: hardening against malicious devices"
    + Acked-by: Oliver Neukum <oneukum@suse.com>
  [PATCH v2 2/4] USB: cdc-acm: handle broken union descriptors
    + Tested-by: Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>
    + Acked-by: Oliver Neukum <oneukum@suse.com>
  [PATCH v2 3/4] USB: cdc-acm: use common data-class define
    + Acked-by: Oliver Neukum <oneukum@suse.com>
  [PATCH v2 4/4] USB: cdc-acm: clean up no-union-descriptor handling
    + Acked-by: Oliver Neukum <oneukum@suse.com>
---
Total patches: 4
---
Cover: ./v2_20200921_johan_usb_cdc_acm_handle_broken_union_descriptors.cover
 Link: https://lore.kernel.org/r/20200921135951.24045-1-johan@kernel.org
 Base: not found
       git am ./v2_20200921_johan_usb_cdc_acm_handle_broken_union_descriptors.mbx

If you look at the mbox, the "cc: stable" is now gone from the
signed-off-by area of the patch.

Johan just noticed this in this discussion of a patch that was "auto
selected" for stable backporting:
	https://lore.kernel.org/linux-usb/20201019070218.GO26280@localhost/

And as I've been using b4 for a few weeks now to apply patches, I don't
know where else this has dropped things :(

I can reproduce this on the current b4 git tree, at commit c0910ee77a2a
("Fix header encoding introduced by earlier fix") as of this moment.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: b4 seems to be dropping "cc: stable" on patches.
  2020-10-19  7:20 b4 seems to be dropping "cc: stable" on patches Greg KH
@ 2020-10-19 12:43 ` Konstantin Ryabitsev
  2020-10-19 13:17   ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Konstantin Ryabitsev @ 2020-10-19 12:43 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: users, tools, Johan Hovold, Sasha Levin

On Mon, Oct 19, 2020 at 09:20:06AM +0200, Greg Kroah-Hartman wrote:
> Hi Konstantin,
> 
> It looks like 'b4' is dropping the cc: stable lines of patches.

Correct, sorry about that -- I was trying to tighten trailer recognition 
to avoid hitting some of the false-positives I've seen and apparently 
this affected Cc: and Link: trailers. :(

This is currently fixed.

> I can reproduce this on the current b4 git tree, at commit c0910ee77a2a
> ("Fix header encoding introduced by earlier fix") as of this moment.

This is one of the dangers of the devel branch, unfortunately -- 
sometimes it ends up with half-baked code. I do need to finally put a 
solid test matrix in place, which is the target for 0.7.0 -- currently 
I'm just continuously running on lkml to find crashers, but it's not a 
good enough solution for finding formatting errors. So, the hope is that 
we'll learn to avoid regressions like this one in the near future.

-K

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: b4 seems to be dropping "cc: stable" on patches.
  2020-10-19 12:43 ` Konstantin Ryabitsev
@ 2020-10-19 13:17   ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-10-19 13:17 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: users, tools, Johan Hovold, Sasha Levin

On Mon, Oct 19, 2020 at 08:43:25AM -0400, Konstantin Ryabitsev wrote:
> On Mon, Oct 19, 2020 at 09:20:06AM +0200, Greg Kroah-Hartman wrote:
> > Hi Konstantin,
> > 
> > It looks like 'b4' is dropping the cc: stable lines of patches.
> 
> Correct, sorry about that -- I was trying to tighten trailer recognition 
> to avoid hitting some of the false-positives I've seen and apparently 
> this affected Cc: and Link: trailers. :(
> 
> This is currently fixed.
> 
> > I can reproduce this on the current b4 git tree, at commit c0910ee77a2a
> > ("Fix header encoding introduced by earlier fix") as of this moment.
> 
> This is one of the dangers of the devel branch, unfortunately -- 
> sometimes it ends up with half-baked code.

Hey, someone has to test the stuff, might as well be people who rely on
it :)

Thanks for fixing this so quickly, much appreciated.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19  7:20 b4 seems to be dropping "cc: stable" on patches Greg KH
2020-10-19 12:43 ` Konstantin Ryabitsev
2020-10-19 13:17   ` Greg KH

Linux maintainer tooling and workflows

Archives are clonable:
	git clone --mirror https://lore.kernel.org/tools/0 tools/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tools tools/ https://lore.kernel.org/tools \
		tools@linux.kernel.org
	public-inbox-index tools

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.linux.tools


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git