b4 crash on staging driver patchset

b4 crash on staging driver patchset

[Greg KH]

Hi Konstantin,

On the latest tip of the 'b4' tree, I get the following crash with this
patch series:

$ b4 am -t https://lore.kernel.org/r/20201019160604.1609180-1-Jerome.Pouiller@silabs.com
Looking up https://lore.kernel.org/r/20201019160604.1609180-1-Jerome.Pouiller%40silabs.com
Grabbing thread from lore.kernel.org/driverdev-devel
Analyzing 3 messages in the thread
---
Writing ./20201019_jerome_pouiller_staging_wfx_fix_use_of_uninitialized_pointer.mbx
Traceback (most recent call last):
  File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 238, in <module>
    cmd()
  File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 221, in cmd
    cmdargs.func(cmdargs)
  File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 40, in cmd_am
    b4.mbox.main(cmdargs)
  File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 509, in main
    mbox_to_am(threadmbox, cmdargs)
  File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 114, in mbox_to_am
    am_mbx = lser.save_am_mbox(mbx, noaddtrailers=cmdargs.noaddtrailers,
  File "/mnt/fast_disk/linux/tools/b4/b4/__init__.py", line 522, in save_am_mbox
    latt.validate(lmsg.msg)
AttributeError: 'NoneType' object has no attribute 'validate'

Any hints?

thanks,

greg k-h

Re: [tools] b4 crash on staging driver patchset

[Konstantin Ryabitsev]

On Tue, Oct 27, 2020 at 01:23:15PM +0100, Greg KH wrote:
> Hi Konstantin,
> 
> On the latest tip of the 'b4' tree, I get the following crash with this
> patch series:
> 
> $ b4 am -t https://lore.kernel.org/r/20201019160604.1609180-1-Jerome.Pouiller@silabs.com

Ah, good find -- we need to fix the horrible base64 encoding legacy crud 
before we try to attest a message. There's a fix for it in the latest 
master.

Thanks!

-K

Re: [tools] b4 crash on staging driver patchset

[Greg KH]

On Tue, Oct 27, 2020 at 08:51:55AM -0400, Konstantin Ryabitsev wrote:
> On Tue, Oct 27, 2020 at 01:23:15PM +0100, Greg KH wrote:
> > Hi Konstantin,
> > 
> > On the latest tip of the 'b4' tree, I get the following crash with this
> > patch series:
> > 
> > $ b4 am -t https://lore.kernel.org/r/20201019160604.1609180-1-Jerome.Pouiller@silabs.com
> 
> Ah, good find -- we need to fix the horrible base64 encoding legacy crud 
> before we try to attest a message. There's a fix for it in the latest 
> master.

Thanks for the quick fix, works for me!

greg k-h