Re: [tools] Exception with b4 am

From: "Mark Brown" <broonie@kernel.org>
To: tools@linux.kernel.org, konstantin@linuxfoundation.org
Subject: Re: [tools] Exception with b4 am
Date: Mon, 23 Nov 2020 16:50:52 +0000	[thread overview]
Message-ID: <20201123165052.GH6322@sirena.org.uk> (raw)
In-Reply-To: <20201123144920.qijmi23rxdibswtb@chatter.i7.local>

[-- Attachment #1: Type: text/plain, Size: 2611 bytes --]

On Mon, Nov 23, 2020 at 09:49:20AM -0500, Konstantin Ryabitsev wrote:
> On Mon, Nov 23, 2020 at 12:41:39PM +0000, Mark Brown wrote:

> > I get the traceback below unless I remove python3-dkim:

> Right, looks like Debian pulls in an older dnspython version. The latest 
> commit I just pushed should work with either.

That fixes the immediate issue but there's more issues with old Python
stuff:

Looking up https://lore.kernel.org/r/1606148273-17325-1-git-send-email-srivasam%40codeaurora.org
Grabbing thread from lore.kernel.org/alsa-devel
Analyzing 1 messages in the thread
---
Writing /tmp/fileDuDx9o.mbx
Traceback (most recent call last):
  File "/home/broonie/git/b4/b4/__init__.py", line 2347, in dkim_get_txt
    a = _resolver.resolve(lookup, dns.rdatatype.TXT, raise_on_no_answer=False, lifetime=timeout, search=True)
AttributeError: 'Resolver' object has no attribute 'resolve'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/broonie/git/b4/b4/command.py", line 220, in <module>
    cmd()
  File "/home/broonie/git/b4/b4/command.py", line 203, in cmd
    cmdargs.func(cmdargs)
  File "/home/broonie/git/b4/b4/command.py", line 40, in cmd_am
    b4.mbox.main(cmdargs)
  File "/home/broonie/git/b4/b4/mbox.py", line 511, in main
    mbox_to_am(threadmbox, cmdargs)
  File "/home/broonie/git/b4/b4/mbox.py", line 117, in mbox_to_am
    linkmask=config['linkmask'], cherrypick=cherrypick)
  File "/home/broonie/git/b4/b4/__init__.py", line 532, in save_am_mbox
    if latt and latt.validate(lmsg.msg):
  File "/home/broonie/git/b4/b4/__init__.py", line 1812, in validate
    self.lsig = LoreAttestationSignatureDKIM(msg)
  File "/home/broonie/git/b4/b4/__init__.py", line 1639, in __init__
    if not dkim.verify(self.msg.as_bytes(), dnsfunc=dkim_get_txt):
  File "/usr/lib/python3/dist-packages/dkim/__init__.py", line 1291, in verify
    return d.verify(dnsfunc=dnsfunc)
  File "/usr/lib/python3/dist-packages/dkim/__init__.py", line 888, in verify
    return self.verify_sig(sig, include_headers, sigheaders[idx], dnsfunc)
  File "/usr/lib/python3/dist-packages/dkim/__init__.py", line 677, in verify_sig
    pk, self.keysize, ktag = load_pk_from_dns(name, dnsfunc)
  File "/usr/lib/python3/dist-packages/dkim/__init__.py", line 423, in load_pk_from_dns
    s = dnsfunc(name)
  File "/home/broonie/git/b4/b4/__init__.py", line 2358, in dkim_get_txt
    _DKIM_DNS_CACHE[name] = dkim.dnsplug.get_txt(name, timeout)
TypeError: get_txt() takes 1 positional argument but 2 were given

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]