Re: b4 Cc: lines

Re: b4 Cc: lines

[Konstantin Ryabitsev]

On Wed, Oct 14, 2020 at 01:47:47PM -0300, Arnaldo Carvalho de Melo wrote:
> 	First of all, thanks a lot for b4, I'm now using it regularly,
> great tool!
> 
> 	My previous workflow involved a 'am' script that I would have to
> use patch by patch, would go on it and collect Cc: lines, not just the
> ones in the patch itself, but the ones in the e-mail containing it, as I
> wanted to record that that group of people was actually made aware of
> that change.
> 
> 	Would it be possible to have something like a --cc to have that?

I added this feature to the latest master, but I'm not 100% sure if it's 
doing the right/useful thing. If we only look for Cc: addresses, then 
more often than not we just find mailing lists there:

----
$ b4 am -o/tmp 20201124143848.874894-1-antonio.borneo@st.com --cc-trailers
Looking up https://lore.kernel.org/r/20201124143848.874894-1-antonio.borneo%40st.com
Grabbing thread from lore.kernel.org/lkml
Analyzing 12 messages in the thread
Will use the latest revision: v2
You can pick other revisions using the -vN flag
---
Writing /tmp/v2_20201124_antonio_borneo_net_phy_realtek_read_actual_speed_on_rtl8211f_to_detect_downshift.mbx
  ✓ [PATCH v2] net: phy: realtek: read actual speed on rtl8211f to detect downshift
    + Cc: linuxarm@huawei.com
    + Cc: Salil Mehta <salil.mehta@huawei.com>
    + Cc: linux-stm32@st-md-mailman.stormreply.com
    + Cc: linux-kernel@vger.kernel.org
  ---
  ✓ Attestation-by: DKIM/st.com (From: antonio.borneo@st.com)
---
Total patches: 1
---
 Link: https://lore.kernel.org/r/20201124215932.885306-1-antonio.borneo@st.com
 Base: 9bd2702d292cb7b565b09e949d30288ab7a26d51
       git checkout -b v2_20201124_antonio_borneo_st_com 9bd2702d292cb7b565b09e949d30288ab7a26d51
       git am /tmp/v2_20201124_antonio_borneo_net_phy_realtek_read_actual_speed_on_rtl8211f_to_detect_downshift.mbx
----

Is it better to look both in To: and Cc:, or did you specifically intend 
to have just the Cc: header copied into the commit?

I'm also a bit worried that on some patches the Cc trailer list ends up 
fairly huge. Is that expected and okay?

-K

Re: b4 Cc: lines

[acme]

Em Tue, Nov 24, 2020 at 05:27:56PM -0500, Konstantin Ryabitsev escreveu:
> On Wed, Oct 14, 2020 at 01:47:47PM -0300, Arnaldo Carvalho de Melo wrote:
> > 	First of all, thanks a lot for b4, I'm now using it regularly,
> > great tool!

> > 	My previous workflow involved a 'am' script that I would have to
> > use patch by patch, would go on it and collect Cc: lines, not just the
> > ones in the patch itself, but the ones in the e-mail containing it, as I
> > wanted to record that that group of people was actually made aware of
> > that change.

> > 	Would it be possible to have something like a --cc to have that?
> 
> I added this feature to the latest master, but I'm not 100% sure if it's 
> doing the right/useful thing. If we only look for Cc: addresses, then 
> more often than not we just find mailing lists there:

I'm using b4 and going thru all the patches, to read them one last time
and do whatever adjustments to the cset logs, so I'll see how this goes
with --cc.

Thanks for adding this feature!

- Arnaldo
 
> ----
> $ b4 am -o/tmp 20201124143848.874894-1-antonio.borneo@st.com --cc-trailers
> Looking up https://lore.kernel.org/r/20201124143848.874894-1-antonio.borneo%40st.com
> Grabbing thread from lore.kernel.org/lkml
> Analyzing 12 messages in the thread
> Will use the latest revision: v2
> You can pick other revisions using the -vN flag
> ---
> Writing /tmp/v2_20201124_antonio_borneo_net_phy_realtek_read_actual_speed_on_rtl8211f_to_detect_downshift.mbx
>   ✓ [PATCH v2] net: phy: realtek: read actual speed on rtl8211f to detect downshift
>     + Cc: linuxarm@huawei.com
>     + Cc: Salil Mehta <salil.mehta@huawei.com>
>     + Cc: linux-stm32@st-md-mailman.stormreply.com
>     + Cc: linux-kernel@vger.kernel.org
>   ---
>   ✓ Attestation-by: DKIM/st.com (From: antonio.borneo@st.com)
> ---
> Total patches: 1
> ---
>  Link: https://lore.kernel.org/r/20201124215932.885306-1-antonio.borneo@st.com
>  Base: 9bd2702d292cb7b565b09e949d30288ab7a26d51
>        git checkout -b v2_20201124_antonio_borneo_st_com 9bd2702d292cb7b565b09e949d30288ab7a26d51
>        git am /tmp/v2_20201124_antonio_borneo_net_phy_realtek_read_actual_speed_on_rtl8211f_to_detect_downshift.mbx
> ----
> 
> Is it better to look both in To: and Cc:, or did you specifically intend 
> to have just the Cc: header copied into the commit?
> 
> I'm also a bit worried that on some patches the Cc trailer list ends up 
> fairly huge. Is that expected and okay?
> 
> -K
> 
> 

-- 

- Arnaldo