tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Konstantin Ryabitsev" <konstantin@linuxfoundation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: tools@linux.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: b4 strips BiugLink
Date: Wed, 9 Dec 2020 08:19:24 -0500	[thread overview]
Message-ID: <20201209131924.bai7b4tj2wb7sbon@chatter.i7.local> (raw)
In-Reply-To: <CACRpkdZrth39GdKc0OFF9cDNHq2hBOXq1f-uU=TOOT8GaogoMQ@mail.gmail.com>

On Wed, Dec 09, 2020 at 09:13:44AM +0100, Linus Walleij wrote:
> Hi Konstantin,
> 
> I ran into this situation with b4, when trying to apply this patch:
> https://lore.kernel.org/linux-gpio/CACRpkdY6gEi6pzuuFCdO_Lj1r23=HKCWF+N+QR-E7kWS8bBkjg@mail.gmail.com/T/#m4ed4e0b58f70c69a0105c73ae8ea7ce8a6f5e61d
> 
> The "BugLink" tag gets stripped.
> 
> Is this on purpose, like b4 strips all unknown tags?

Yeah, I had to come up with some kind of "known trailers" list for what 
I call "non-person" trailers. It's easy to recognize a sign-off trailer, 
because it almost always follows the same format:

[\w-]: Name Here <email@here>

However, non-person trailers can be anything and we were routinely 
hitting false-positives whenever someone did stuff like:

See: https://foo.bar/baz
Example: https://foo.bar/baz
Ugh: https://foo.bar/baz
WTF: https://foo.bar.baz

> It seems BugLink is important to Intel so we better allow it
> in that case.

Okay, there is a fix in master and stable-0.6.y that adds BugLink to the 
list.

-K

  parent reply	other threads:[~2020-12-09 13:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09  8:13 b4 strips BiugLink Linus Walleij
2020-12-09 10:24 ` Andy Shevchenko
2020-12-09 13:19 ` Konstantin Ryabitsev [this message]
2020-12-09 14:40   ` Linus Walleij
2020-12-09 16:53     ` Andy Shevchenko
2020-12-09 17:10       ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209131924.bai7b4tj2wb7sbon@chatter.i7.local \
    --to=konstantin@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).