Linux maintainer tooling and workflows
 help / color / Atom feed
* b4 strips BiugLink
@ 2020-12-09  8:13 Linus Walleij
  2020-12-09 10:24 ` Andy Shevchenko
  2020-12-09 13:19 ` Konstantin Ryabitsev
  0 siblings, 2 replies; 6+ messages in thread
From: Linus Walleij @ 2020-12-09  8:13 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools, Andy Shevchenko

Hi Konstantin,

I ran into this situation with b4, when trying to apply this patch:
https://lore.kernel.org/linux-gpio/CACRpkdY6gEi6pzuuFCdO_Lj1r23=HKCWF+N+QR-E7kWS8bBkjg@mail.gmail.com/T/#m4ed4e0b58f70c69a0105c73ae8ea7ce8a6f5e61d

The "BugLink" tag gets stripped.

Is this on purpose, like b4 strips all unknown tags?

It seems BugLink is important to Intel so we better allow it
in that case.

Thanks!
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: b4 strips BiugLink
  2020-12-09  8:13 b4 strips BiugLink Linus Walleij
@ 2020-12-09 10:24 ` Andy Shevchenko
  2020-12-09 13:19 ` Konstantin Ryabitsev
  1 sibling, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2020-12-09 10:24 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Konstantin Ryabitsev, tools

On Wed, Dec 09, 2020 at 09:13:44AM +0100, Linus Walleij wrote:
> Hi Konstantin,
> 
> I ran into this situation with b4, when trying to apply this patch:
> https://lore.kernel.org/linux-gpio/CACRpkdY6gEi6pzuuFCdO_Lj1r23=HKCWF+N+QR-E7kWS8bBkjg@mail.gmail.com/T/#m4ed4e0b58f70c69a0105c73ae8ea7ce8a6f5e61d
> 
> The "BugLink" tag gets stripped.
> 
> Is this on purpose, like b4 strips all unknown tags?
> 
> It seems BugLink is important to Intel so we better allow it
> in that case.

FYI:

% git log --oneline --grep BugLink v5.10-rc7 | wc -l
772

% git log --oneline --grep Buglink v5.10-rc7 | wc -l
29

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: b4 strips BiugLink
  2020-12-09  8:13 b4 strips BiugLink Linus Walleij
  2020-12-09 10:24 ` Andy Shevchenko
@ 2020-12-09 13:19 ` Konstantin Ryabitsev
  2020-12-09 14:40   ` Linus Walleij
  1 sibling, 1 reply; 6+ messages in thread
From: Konstantin Ryabitsev @ 2020-12-09 13:19 UTC (permalink / raw)
  To: Linus Walleij; +Cc: tools, Andy Shevchenko

On Wed, Dec 09, 2020 at 09:13:44AM +0100, Linus Walleij wrote:
> Hi Konstantin,
> 
> I ran into this situation with b4, when trying to apply this patch:
> https://lore.kernel.org/linux-gpio/CACRpkdY6gEi6pzuuFCdO_Lj1r23=HKCWF+N+QR-E7kWS8bBkjg@mail.gmail.com/T/#m4ed4e0b58f70c69a0105c73ae8ea7ce8a6f5e61d
> 
> The "BugLink" tag gets stripped.
> 
> Is this on purpose, like b4 strips all unknown tags?

Yeah, I had to come up with some kind of "known trailers" list for what 
I call "non-person" trailers. It's easy to recognize a sign-off trailer, 
because it almost always follows the same format:

[\w-]: Name Here <email@here>

However, non-person trailers can be anything and we were routinely 
hitting false-positives whenever someone did stuff like:

See: https://foo.bar/baz
Example: https://foo.bar/baz
Ugh: https://foo.bar/baz
WTF: https://foo.bar.baz

> It seems BugLink is important to Intel so we better allow it
> in that case.

Okay, there is a fix in master and stable-0.6.y that adds BugLink to the 
list.

-K

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: b4 strips BiugLink
  2020-12-09 13:19 ` Konstantin Ryabitsev
@ 2020-12-09 14:40   ` Linus Walleij
  2020-12-09 16:53     ` Andy Shevchenko
  0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2020-12-09 14:40 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools, Andy Shevchenko

On Wed, Dec 9, 2020 at 2:19 PM Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:

> Okay, there is a fix in master and stable-0.6.y that adds BugLink to the
> list.

Wow that's quick!

Thanks a lot Konstantin!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: b4 strips BiugLink
  2020-12-09 14:40   ` Linus Walleij
@ 2020-12-09 16:53     ` Andy Shevchenko
  2020-12-09 17:10       ` Konstantin Ryabitsev
  0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2020-12-09 16:53 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Konstantin Ryabitsev, tools

On Wed, Dec 09, 2020 at 03:40:40PM +0100, Linus Walleij wrote:
> On Wed, Dec 9, 2020 at 2:19 PM Konstantin Ryabitsev
> <konstantin@linuxfoundation.org> wrote:
> 
> > Okay, there is a fix in master and stable-0.6.y that adds BugLink to the
> > list.
> 
> Wow that's quick!
> 
> Thanks a lot Konstantin!

Thanks!

Btw, can b4 print a warning if it cuts an (unknown) tag?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: b4 strips BiugLink
  2020-12-09 16:53     ` Andy Shevchenko
@ 2020-12-09 17:10       ` Konstantin Ryabitsev
  0 siblings, 0 replies; 6+ messages in thread
From: Konstantin Ryabitsev @ 2020-12-09 17:10 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Linus Walleij, tools

On Wed, Dec 09, 2020 at 06:53:56PM +0200, Andy Shevchenko wrote:
> > > Okay, there is a fix in master and stable-0.6.y that adds BugLink 
> > > to the
> > > list.
> > 
> > Wow that's quick!
> > 
> > Thanks a lot Konstantin!
> 
> Thanks!
> 
> Btw, can b4 print a warning if it cuts an (unknown) tag?

I can actually improve on the algorithm. We only need to be cautious 
about stuff sent as follow-ups -- anything that is part of the commit 
message already doesn't need to be scrutinized.

I'll put in a fix that just accepts trailers seen in patch series itself 
without checking.

-K

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09  8:13 b4 strips BiugLink Linus Walleij
2020-12-09 10:24 ` Andy Shevchenko
2020-12-09 13:19 ` Konstantin Ryabitsev
2020-12-09 14:40   ` Linus Walleij
2020-12-09 16:53     ` Andy Shevchenko
2020-12-09 17:10       ` Konstantin Ryabitsev

Linux maintainer tooling and workflows

Archives are clonable:
	git clone --mirror https://lore.kernel.org/tools/0 tools/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tools tools/ https://lore.kernel.org/tools \
		tools@linux.kernel.org
	public-inbox-index tools

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.linux.tools


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git