tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mark Brown" <broonie@kernel.org>
To: tools@linux.kernel.org, konstantin@linuxfoundation.org
Subject: b4 ty unicode crash
Date: Mon, 28 Dec 2020 16:13:47 +0000	[thread overview]
Message-ID: <20201228161347.GD5352@sirena.org.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

Hi,

When I run b4 ty and it finds what looks like:

   https://lore.kernel.org/r/ec66399502514edbb1de3cf9bff08b1d@realtek.com

I get a traceback:

Generating 4 thank-you letters
Traceback (most recent call last):
  File "/home/broonie/git/b4/b4/command.py", line 236, in <module>
    cmd()
  File "/home/broonie/git/b4/b4/command.py", line 219, in cmd
    cmdargs.func(cmdargs)
  File "/home/broonie/git/b4/b4/command.py", line 61, in cmd_ty
    b4.ty.main(cmdargs)
  File "/home/broonie/git/b4/b4/ty.py", line 638, in main
    auto_thankanator(cmdargs)
  File "/home/broonie/git/b4/b4/ty.py", line 392, in auto_thankanator
    send_messages(applied, cmdargs.gitdir, cmdargs.outdir, wantbranch, since=cmdargs.since)
  File "/home/broonie/git/b4/b4/ty.py", line 429, in send_messages
    msg = generate_am_thanks(gitdir, jsondata, branch, since)
  File "/home/broonie/git/b4/b4/ty.py", line 351, in generate_am_thanks
    msg = make_reply(thanks_template, jsondata)
  File "/home/broonie/git/b4/b4/ty.py", line 96, in make_reply
    msg['Cc'] = b4.format_addrs(allcc)
  File "/home/broonie/git/b4/b4/__init__.py", line 2382, in format_addrs
    addrs.add(email.utils.formataddr((LoreMessage.clean_header(pair[0]), LoreMessage.clean_header(pair[1]))))
  File "/usr/lib/python3.7/email/utils.py", line 91, in formataddr
    address.encode('ascii')
UnicodeEncodeError: 'ascii' codec can't encode characters in position 22-24: ordinal not in range(128)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]

             reply	other threads:[~2020-12-28 16:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 16:13 Mark Brown [this message]
2020-12-28 16:56 ` b4 ty unicode crash Konstantin Ryabitsev
2020-12-28 18:18 ` Konstantin Ryabitsev
2020-12-29 12:16   ` [tools] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201228161347.GD5352@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).