From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: tools@linux.kernel.org
Subject: Re: b4 corrupts patch
Date: Thu, 8 Apr 2021 12:18:33 -0400 [thread overview]
Message-ID: <20210408161833.icwv2ncdm37dvzbs@nitro.local> (raw)
In-Reply-To: <20210408160226.GA1932146@bjorn-Precision-5520>
On Thu, Apr 08, 2021 at 11:02:26AM -0500, Bjorn Helgaas wrote:
> b4 seems to corrupt this patch when fetching and adding a Reviewed-by
> tag:
>
> https://lore.kernel.org/r/b411af88-5049-a1c6-83ac-d104a1f429be@huawei.com
Hmm... this is because the trailers are separated from the basement using '--'
and not '---'. Git gets confused, too, as if you apply the patch, you will get
this at the bottom of your commit message.
--
v2: rewrite subject and commit log as suggested by Bjorn Helgaas.
b4 messes things up a bit more because we mis-recognize that line as a trailer
and move "--" above the rest of the trailers (at least "git mailinfo" breaks
it up that way).
I'm not sure if I should fix this or not, as this is not a well-formed patch
to begin with.
Suggestions?
-K
next prev parent reply other threads:[~2021-04-08 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 16:02 b4 corrupts patch Bjorn Helgaas
2021-04-08 16:18 ` Konstantin Ryabitsev [this message]
2021-04-08 17:01 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408161833.icwv2ncdm37dvzbs@nitro.local \
--to=konstantin@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).