tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
* Issues escaping Froms
@ 2021-09-21 11:55 Mark Brown
  2021-09-21 12:49 ` Konstantin Ryabitsev
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2021-09-21 11:55 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Attempting to fetch 2d221984-7a2e-7006-0f8a-ffb5f64ee885@axentia.se with
b4 am I get a mailbox which is for example interpreted by mutt as:

->    1 N   09/16 Peter Rosin     (1.7K)
      2 N C 09/20 Peter Rosin     (  0K) [PATCH] ASoC: pcm512x: Mend accesses to

Due to the fact that the message has a From line in it as well as a
From: but that doesn't get escaped by b4 so mail software interprets it
as the start of a new message in the mailbox.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Issues escaping Froms
  2021-09-21 11:55 Issues escaping Froms Mark Brown
@ 2021-09-21 12:49 ` Konstantin Ryabitsev
  2021-09-23 12:08   ` Mark Brown
  0 siblings, 1 reply; 4+ messages in thread
From: Konstantin Ryabitsev @ 2021-09-21 12:49 UTC (permalink / raw)
  To: Mark Brown; +Cc: tools

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Tue, Sep 21, 2021 at 12:55:44PM +0100, Mark Brown wrote:
> Attempting to fetch 2d221984-7a2e-7006-0f8a-ffb5f64ee885@axentia.se with
> b4 am I get a mailbox which is for example interpreted by mutt as:
> 
> ->    1 N   09/16 Peter Rosin     (1.7K)
>       2 N C 09/20 Peter Rosin     (  0K) [PATCH] ASoC: pcm512x: Mend accesses to
> 
> Due to the fact that the message has a From line in it as well as a
> From: but that doesn't get escaped by b4 so mail software interprets it
> as the start of a new message in the mailbox.

Unfortunately, the "mbox" files that git expects for "git am" are not the
"mbox" files expected by mutt and other MUAs. If we escape the "From " entries
as mandated by the format, they don't get unescaped by "git am" and make their
way into git commits:

    https://git.kernel.org/torvalds/c/137733d08f4a

There is no working around this, short of saving everything as maildirs.

-K

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Issues escaping Froms
  2021-09-21 12:49 ` Konstantin Ryabitsev
@ 2021-09-23 12:08   ` Mark Brown
  2021-09-23 12:31     ` Konstantin Ryabitsev
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2021-09-23 12:08 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

On Tue, Sep 21, 2021 at 08:49:26AM -0400, Konstantin Ryabitsev wrote:

> Unfortunately, the "mbox" files that git expects for "git am" are not the
> "mbox" files expected by mutt and other MUAs. If we escape the "From " entries
> as mandated by the format, they don't get unescaped by "git am" and make their
> way into git commits:
> 
>     https://git.kernel.org/torvalds/c/137733d08f4a
> 
> There is no working around this, short of saving everything as maildirs.

Hrm, right.  That's awesome.  There's something fishy going on here
somewhere thoguh - I'm also seeing it failing to find the patch in

    60f0c65bbd52479cb83683b8475af435@bytesnap.co.uk

which has similar kinds of malformation in the incoming message, though
the result ends up different.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Issues escaping Froms
  2021-09-23 12:08   ` Mark Brown
@ 2021-09-23 12:31     ` Konstantin Ryabitsev
  0 siblings, 0 replies; 4+ messages in thread
From: Konstantin Ryabitsev @ 2021-09-23 12:31 UTC (permalink / raw)
  To: Mark Brown; +Cc: tools

On Thu, Sep 23, 2021 at 01:08:20PM +0100, Mark Brown wrote:
> > There is no working around this, short of saving everything as maildirs.
> 
> Hrm, right.  That's awesome.  There's something fishy going on here
> somewhere thoguh - I'm also seeing it failing to find the patch in
> 
>     60f0c65bbd52479cb83683b8475af435@bytesnap.co.uk

Hmm... this looks like a bug. I'll check it out.

-K

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-23 12:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-21 11:55 Issues escaping Froms Mark Brown
2021-09-21 12:49 ` Konstantin Ryabitsev
2021-09-23 12:08   ` Mark Brown
2021-09-23 12:31     ` Konstantin Ryabitsev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).