From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: tools@linux.kernel.org
Subject: Re: [PATCH] shazam: Add the --add-message-id argument
Date: Mon, 27 Feb 2023 14:03:48 -0500 [thread overview]
Message-ID: <20230227190348.wbvqvpduk74x5yy4@meerkat.local> (raw)
In-Reply-To: <mhng-285f5c62-3d67-44c8-b2d0-64c8840b3873@palmer-ri-x1c9a>
On Mon, Feb 27, 2023 at 11:00:03AM -0800, Palmer Dabbelt wrote:
> > I'd like to go a slightly different way about it. We already have a
> > "b4.linkmask" parameter, so I suggest we also add "b4.linktrailer", such as
> > you can specify:
> >
> > [b4]
> > linktrailer = Message-ID
> > linkmask = <%s>
> >
> > This would additionally allow someone to differentiate Link trailers that
> > point at code-review links vs. any other links.
> >
> > Does that sound like a potential alternative to creating another runtime flag?
>
> IIUC I can put that in each repo's config? In that case it's actually
> better, as I don't need to remember to type "-l" in Linux and "-I" in QEMU
> ;)
Yes, and you can also add it to wtglobs in get_main_config() in init.py, which
should allow setting this in .b4-config for projects that want to add that to
their toplevel.
Do you feel like doing a v2 with this change?
-K
next prev parent reply other threads:[~2023-02-27 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 16:48 [PATCH] shazam: Add the --add-message-id argument Palmer Dabbelt
2023-02-27 18:48 ` Konstantin Ryabitsev
2023-02-27 19:00 ` Palmer Dabbelt
2023-02-27 19:03 ` Konstantin Ryabitsev [this message]
2023-02-27 19:05 ` Palmer Dabbelt
2023-02-27 20:09 ` Konstantin Ryabitsev
2023-02-27 20:26 ` Palmer Dabbelt
2023-02-27 20:47 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227190348.wbvqvpduk74x5yy4@meerkat.local \
--to=konstantin@linuxfoundation.org \
--cc=palmer@rivosinc.com \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).