tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joel Granados <j.granados@samsung.com>
To: <tools@kernel.org>
Subject: b4 is bringing a bit too many trailers
Date: Fri, 3 May 2024 14:05:06 +0200	[thread overview]
Message-ID: <20240503120506.p7g5nn6jocrrdlck@joelS2.panther.com> (raw)
In-Reply-To: CGME20240503120511eucas1p2a3362abf193471c9b56bd7c2cdcbb79d@eucas1p2.samsung.com

[-- Attachment #1: Type: text/plain, Size: 2423 bytes --]

Hey 

I'm hitting unexpected behavior when I use the "trailer" command. Here
is what I see.

1. Locally I'm standing on the most resent version of "sysctl: Remove
   sentinel elements from networking"
   https://lore.kernel.org/arll/20240501-jag-sysctl_remset_net-v6-0-370b702b6b4a@samsung.com

2. I do a `b4 trailers -u -F "20240501-jag-sysctl_remset_net-v6-0-370b702b6b4a@samsung.com"`
   to bring in all the trailers from v6.

3. It adds the following trailers:
      Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
      Acked-by: Chuck Lever <chuck.lever@oracle.com>
      Reviewed-by: Jeffrey Layton <jlayton@kernel.org>
      Acked-by: Allison Henderson <allison.henderson@oracle.com>
      Tested-by: Valentin Schneider <vschneid@redhat.com>
      Reviewed-by: Valentin Schneider <vschneid@redhat.com>
      Reviewed-by: Muchun Song <muchun.song@linux.dev>
      Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
      Acked-by: Kees Cook <keescook@chromium.org>

4. The first 4 are valid trailers for "20240501-jag-sysctl_remset_net-v6-0-370b702b6b4a@samsung.com"
   But the last 5 are not.

5. Here is where I think the others came from:
  5.1 "Acked-by: Kees Cook <keescook@chromium.org>":
      can be found here https://lore.kernel.org/all/202404150906.C37D8D9DA1@keescook/ but
      it is part of "[PATCH 0/7] sysctl: Remove sentinel elements from misc directories"

  5.2 "Reviewed-by: Muchun Song <muchun.song@linux.dev>"
      "Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>"
      can be found here https://lore.kernel.org/all/0e35e88d-3ea1-4f62-77e4-eb12e9f51583@huawei.com/
      and here  https://lore.kernel.org/all/8E19B519-9035-42E0-92DC-7C21471543D8@linux.dev/
      but it is part of "[PATCH 0/7] sysctl: Remove sentinel elements from misc directories"

  5.3 "Tested-by: Valentin Schneider <vschneid@redhat.com>"
      "Reviewed-by: Valentin Schneider <vschneid@redhat.com>"
      can be found here https://lore.kernel.org/all/xhsmhil0qaoz7.mognet@vschneid-thinkpadt14sgen2i.remote.csb/
      but is part of "[PATCH v3 00/10] sysctl: Remove sentinel elements from kernel dir"

6. b4 --version -> 0.13.0

My expectation is that only the first 4 trailers be brought in. Not sure
why the others are leaking into my command. Please get back to me if you
need me to do further testing.

BTW: I'm loving the b4 workflow!.

Best

-- 

Joel Granados

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

       reply	other threads:[~2024-05-03 12:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240503120511eucas1p2a3362abf193471c9b56bd7c2cdcbb79d@eucas1p2.samsung.com>
2024-05-03 12:05 ` Joel Granados [this message]
2024-05-03 13:22   ` b4 is bringing a bit too many trailers Konstantin Ryabitsev
2024-05-03 14:17     ` Joel Granados

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240503120506.p7g5nn6jocrrdlck@joelS2.panther.com \
    --to=j.granados@samsung.com \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).