tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robherring2@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Leon Romanovsky <leon@kernel.org>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	ksummit@lists.linux.dev, tools@linux.kernel.org
Subject: Re: [MAINTAINER SUMMIT] Rethinking the acceptance policy for "trivial" patches
Date: Thu, 22 Apr 2021 23:46:31 -0700	[thread overview]
Message-ID: <6c221d801c5a6834168207b5ccadc76ac432c766.camel@perches.com> (raw)
In-Reply-To: <20210423080454.78f4f662@coco.lan>

On Fri, 2021-04-23 at 08:04 +0200, Mauro Carvalho Chehab wrote:
> I have a script to automate it, but I had to tweak it while handling
> patches that cross a single subsystem boundaries, using git send-email
> with the c/c list obtained from get_maintainers.pl.
> 
> By default, the script adds all maintainers, reviewers and all mailing
> lists to the cover letter, but that sometimes generate a cover letter
> with 80+ c/c, which will be automatically rejected by anti-spam
> measures and by mail servers.
> 
> So, I played with two different alternatives:
> 
> 1. At the beginning, I changed the script to c/c only the mailing lists,
>    excluding maintainers/reviewers;
> 2. As the feedback was not great, I changed the script to c/c only
>    the maintainers, excluding mailing lists/reviewers. It seems that
>    this worked better.
> 
> I didn't try to play with bcc, as replying to it would not send
> the replies to everyone.
> 
> If you think it is worth, I could submit it to scripts/, but I
> suspect we may need to adjust it to work with all maintainers'
> workflows.

I have a very similar script

A portion of a cc script I use tests whether cc'ing the cover letter
to all listed maintainers of a patch series creates a header of less
than 512 chars and if so cc's all relevant maintainers, otherwise it
just cc's the mailing lists.

(Ingo didn't/doesn't want to receive any emails from me)

$ cat ~/bin/remove_undesirable_emails.sh
grep -vPi "(?:\bIngo\s+Molnar\b)"

$ cat ~/bin/cc.sh
#!/bin/bash

opts="--nogit --nogit-fallback --norolestats"
maint_file=$(mktemp -t XXXXXXXX.cc)

if [[ $(basename $1) =~ ^0000- ]] ; then
    ./scripts/get_maintainer.pl $opts $(dirname $1)/* |  \
	~/bin/remove_undesirable_emails.sh > $maint_file
    count=$(wc -c $maint_file | cut -f1 -d" ")
    if [[ $count -lt 512 ]] ; then
	cat $maint_file
    else
	./scripts/get_maintainer.pl -nom -nor $opts $(dirname $1)/* | \
	    ~/bin/remove_undesirable_emails.sh
    fi

...


  reply	other threads:[~2021-04-23 15:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <afc5664dc2b60f912dd97abfa818b3f7c4237b92.camel@HansenPartnership.com>
     [not found] ` <YID5xhy2vv45fnOv@unreal>
     [not found]   ` <20210422112001.22c64fe9@coco.lan>
     [not found]     ` <20210422125357.uuxprp6rqxewcdsr@nitro.local>
     [not found]       ` <YIG43TuqmxU24evq@unreal>
2021-04-22 18:05         ` backfilling threads with b4 (was: Re: [MAINTAINER SUMMIT] Rethinking the acceptance policy for "trivial" patches) Konstantin Ryabitsev
2021-04-22 18:51           ` Leon Romanovsky
2021-04-25 10:58           ` Leon Romanovsky
     [not found]     ` <YIFfXTVMDmHwVmSR@unreal>
     [not found]       ` <20210422092916.556e5e50@gandalf.local.home>
     [not found]         ` <CAL_JsqKS-=shqkLhzKeLHqNPhosGJw5X-fOi+dy1rT3Q_LfBZg@mail.gmail.com>
2021-04-23  6:04           ` [MAINTAINER SUMMIT] Rethinking the acceptance policy for "trivial" patches Mauro Carvalho Chehab
2021-04-23  6:46             ` Joe Perches [this message]
2021-04-23  7:13               ` Mauro Carvalho Chehab
2021-04-23  7:20                 ` [PATCH RFC] scripts: add a script for sending patches Mauro Carvalho Chehab
2021-04-23 14:52                 ` Better tools for sending patches (was: Re: [MAINTAINER SUMMIT] Rethinking the acceptance policy for "trivial" patches) Doug Anderson
2021-04-23 16:03                   ` Mark Brown
2021-04-23 17:12                     ` Leon Romanovsky
2021-04-26 23:50                       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c221d801c5a6834168207b5ccadc76ac432c766.camel@perches.com \
    --to=joe@perches.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=ksummit@lists.linux.dev \
    --cc=leon@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robherring2@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).