Linux maintainer tooling and workflows
 help / color / Atom feed
* Trying to figure out why your attestation is failing
@ 2020-09-08 17:58 Konstantin Ryabitsev
  2020-09-14  9:13 ` Neil Armstrong
  0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Ryabitsev @ 2020-09-08 17:58 UTC (permalink / raw)
  To: narmstrong; +Cc: tools

Neil:

I am keeping an eye on attestation emails sent to the signatures list 
(https://lore.kernel.org/signatures/) and I noticed that b4 isn't 
properly finding your attestation data. I poked at this series:

- thread: https://lore.kernel.org/linux-amlogic/20200907081825.1654-1-narmstrong@baylibre.com
- attestation: https://lore.kernel.org/signatures/159946699508.19944.11132773619713429568@kernel.org

When we generate attestation hashes from the patches you submitted, we 
get a different value for the "i" hash:

$ git mailinfo m p < 0001-dt-bindings-display-amlogic-meson-vpu-add-bindings-f.patch | egrep '^(Author|Email|Subject)' | sha256sum
7158b7d79fbd5342923a63ea14701fa75061a856f6eb30c9dfe83672894113ba -

Apparently, when you run it on your system during attestation generation 
step, you get a different hash for i:

3753d76c-4b385c46-aa69b83c:
  i: 3753d76ca01efcc78b682dc0f9feb582d67a1e9a6a89b0519cdf54a36eee5e0b
  m: 4b385c46651635915366eba13de55a445ae3d41afd2d0e5da8bad270a08c0e70
  p: aa69b83c2b5d484b33deec0c59135fdfe7290b658f29527590261abab8a4ac51

This is why when we're trying to find your attestation document, we are 
not finding it:

  Cache says looking up 7158b7d7-4b385c46-aa69b83c = 404

I am curious why this happens -- either the patches generated on your 
system have different Author/Email/Subject values until git-send-email actually
runs, or git mailinfo output has changed between revisions. I would like to
understand this better so we can properly address it, if you're willing to lend
a hand.

Best,
Konstantin

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Trying to figure out why your attestation is failing
  2020-09-08 17:58 Trying to figure out why your attestation is failing Konstantin Ryabitsev
@ 2020-09-14  9:13 ` Neil Armstrong
  0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2020-09-14  9:13 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools

Hi,

On 08/09/2020 19:58, Konstantin Ryabitsev wrote:
> Neil:
> 
> I am keeping an eye on attestation emails sent to the signatures list 
> (https://lore.kernel.org/signatures/) and I noticed that b4 isn't 
> properly finding your attestation data. I poked at this series:
> 
> - thread: https://lore.kernel.org/linux-amlogic/20200907081825.1654-1-narmstrong@baylibre.com
> - attestation: https://lore.kernel.org/signatures/159946699508.19944.11132773619713429568@kernel.org
> 
> When we generate attestation hashes from the patches you submitted, we 
> get a different value for the "i" hash:
> 
> $ git mailinfo m p < 0001-dt-bindings-display-amlogic-meson-vpu-add-bindings-f.patch | egrep '^(Author|Email|Subject)' | sha256sum
> 7158b7d79fbd5342923a63ea14701fa75061a856f6eb30c9dfe83672894113ba -
> 
> Apparently, when you run it on your system during attestation generation 
> step, you get a different hash for i:
> 
> 3753d76c-4b385c46-aa69b83c:
>   i: 3753d76ca01efcc78b682dc0f9feb582d67a1e9a6a89b0519cdf54a36eee5e0b
>   m: 4b385c46651635915366eba13de55a445ae3d41afd2d0e5da8bad270a08c0e70
>   p: aa69b83c2b5d484b33deec0c59135fdfe7290b658f29527590261abab8a4ac51
> 
> This is why when we're trying to find your attestation document, we are 
> not finding it:
> 
>   Cache says looking up 7158b7d7-4b385c46-aa69b83c = 404
> 
> I am curious why this happens -- either the patches generated on your 
> system have different Author/Email/Subject values until git-send-email actually
> runs, or git mailinfo output has changed between revisions. I would like to
> understand this better so we can properly address it, if you're willing to lend
> a hand.

Indeed, I usually only add partial To/Cc directly in the patches and the patchset-wise
to git send-email, would it be the issue ?

Neil

> 
> Best,
> Konstantin
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 17:58 Trying to figure out why your attestation is failing Konstantin Ryabitsev
2020-09-14  9:13 ` Neil Armstrong

Linux maintainer tooling and workflows

Archives are clonable:
	git clone --mirror https://lore.kernel.org/tools/0 tools/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tools tools/ https://lore.kernel.org/tools \
		tools@linux.kernel.org
	public-inbox-index tools

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.linux.tools


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git