From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@linux.kernel.org, users@linux.kernel.org
Subject: Multi-patch series broken in b4 master
Date: Fri, 11 Jun 2021 13:55:29 +0200 [thread overview]
Message-ID: <CAMuHMdWakx2RcL4W_cmUh8s3NYp3darGmrVu11Hq2-sY0GqUPg@mail.gmail.com> (raw)
Hi Konstantin,
Commit c2e1aa9cbbf3d89a ("Save exploded pull requests as maildirs
as well") broke patch series containing more than one patch, as the
resulting .mbx file no longer has the needed separators between emails.
I first noticed when using formail and checkpatch:
$ cat *mbx | formail -s scripts/checkpatch.pl
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28:
new file mode 100644
WARNING: DT binding docs and includes should be a separate patch.
See: Documentation/devicetree/bindings/submitting-patches.rst
WARNING: email address 'linux-clk@vger.kernel.org,
devicetree@vger.kernel.org' might be better as
'linux-clk@vger.kernel.org devicetree@vger.kernel.org'
#131:
To: linux-clk@vger.kernel.org, devicetree@vger.kernel.org
WARNING: Unexpected content after email:
'linux-clk@vger.kernel.org, devicetree@vger.kernel.org', should be:
'linux-clk@vger.kernel.org (devicetree@vger.kernel.org)'
#131:
To: linux-clk@vger.kernel.org, devicetree@vger.kernel.org
WARNING: Duplicate signature
#144:
Signed-off-by: Daniel Mack <daniel@zonque.org>
[...]
But apparently "git am" has issues with the .mbx file, too:
b4 master:
$ b4 am 20210519201551.690654-1-daniel@zonque.org
Looking up https://lore.kernel.org/r/20210519201551.690654-1-daniel%40zonque.org
Analyzing 7 messages in the thread
Checking attestation on all messages, may take a moment...
---
[PATCH v2 1/3] dt-bindings: clock: convert cs2000-cp bindings to yaml
+ Reviewed-by: Rob Herring <robh@kernel.org>
[PATCH v2 2/3] dt-bindings: clock: cs2000-cp: Document aux-output-source
+ Reviewed-by: Rob Herring <robh@kernel.org>
[PATCH v2 3/3] clk: cs2000-cp: Make aux output function controllable
---
Total patches: 3
---
Cover: ./v2_20210519_daniel_clk_cs2000_cp_make_aux_output_pin_configurable.cover
Link: https://lore.kernel.org/r/20210519201551.690654-1-daniel@zonque.org
Base: not found (applies clean to current tree)
git am
./v2_20210519_daniel_clk_cs2000_cp_make_aux_output_pin_configurable.mbx
$ git am -s *mbx
Applying: dt-bindings: clock: convert cs2000-cp bindings to yaml
And the single commit contains the changes of all 3 patches.
b4 v0.7.2:
$ b4 am 20210519201551.690654-1-daniel@zonque.org
Looking up https://lore.kernel.org/r/20210519201551.690654-1-daniel%40zonque.org
Analyzing 7 messages in the thread
Checking attestation on all messages, may take a moment...
---
[PATCH v2 1/3] dt-bindings: clock: convert cs2000-cp bindings to yaml
+ Reviewed-by: Rob Herring <robh@kernel.org>
[PATCH v2 2/3] dt-bindings: clock: cs2000-cp: Document aux-output-source
+ Reviewed-by: Rob Herring <robh@kernel.org>
[PATCH v2 3/3] clk: cs2000-cp: Make aux output function controllable
---
Total patches: 3
---
Cover: ./v2_20210519_daniel_clk_cs2000_cp_make_aux_output_pin_configurable.cover
Link: https://lore.kernel.org/r/20210519201551.690654-1-daniel@zonque.org
Base: not found (applies clean to current tree)
git am
./v2_20210519_daniel_clk_cs2000_cp_make_aux_output_pin_configurable.mbx
$ git am -s *mbx
Applying: dt-bindings: clock: convert cs2000-cp bindings to yaml
Applying: dt-bindings: clock: cs2000-cp: Document aux-output-source
Applying: clk: cs2000-cp: Make aux output function controllable
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2021-06-11 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 11:55 Geert Uytterhoeven [this message]
2021-06-11 12:37 ` Multi-patch series broken in b4 master Konstantin Ryabitsev
2021-06-11 14:16 ` Konstantin Ryabitsev
2021-06-11 18:29 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWakx2RcL4W_cmUh8s3NYp3darGmrVu11Hq2-sY0GqUPg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).