tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "James Bottomley" <James.Bottomley@HansenPartnership.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	toke@toke.dk,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	users@linux.kernel.org,  tools@linux.kernel.org,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [kernel.org users] b4: encouraging using the cover letter in merge commits?
Date: Sat, 19 Dec 2020 13:01:43 -0800	[thread overview]
Message-ID: <e700a8744c3b32070977bf672cd6788e12d6b7d5.camel@HansenPartnership.com> (raw)
In-Reply-To: <20201219204832.GA363602@kernel.org>

On Sat, 2020-12-19 at 17:48 -0300, Arnaldo Carvalho de Melo wrote:
> Em Sat, Dec 19, 2020 at 11:03:59AM -0800, James Bottomley escreveu:
> > On Sat, 2020-12-19 at 11:57 -0700, Jonathan Corbet wrote:
[...]
> > > We're getting into minor details, though.  If The Community were
> > > to decide somehow that link tags are The Preferred Way, I would
> > > not kick and scream too hard before going along with it.  Unless
> > > I were in one of my screaming moods at the time, of course.
> > 
> > I'm not really seeking a preferred way, I'm just asking why people
> > who now use the link tag and linear series should change.  As long
> > as we can agree the link tag is fine and there's really no
> > additional information that needs capturing, I think we can leave
> > it to maintainer discretion whether they prefer merge per series or
> > linear.
> 
> My question is: is the information in the cover letter useful? 

I think it is but it's not vital to understanding individual commits,
which should be properly described.

> If it is, why not have it preserved in the main repo?

Because the link tag supplies it and works with current linear
workflows.  To mandate storing the cover letter, people using linear
workflows have to move to a new method.

>  The owner of such repositories asks us to describe what is in the
> series, sign it, and then this gets dropped?

Um, well we don't have people sign the cover letter.  We just have it
describe the current series and its history.  Plus it doesn't get
dropped ... it's in the email history, pointed to by the link tag,
which is often a lot richer than the bare cover letter anyway.

The main point is we have two pieces of information:  The precise
description of what each commit does, which should be in the tree.  And
the historical record of how the patch series got to where it was
committed, which is in the email archives.  The the cover letter is
usually not an accurate synopsis of this, which is why I prefer link
tags to the full history, but my preference isn't strong enough to
overrule people who want to store the cover letter.

James



  reply	other threads:[~2020-12-19 21:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 21:32 b4: encouraging using the cover letter in merge commits? Toke Høiland-Jørgensen
2020-12-18 22:09 ` Konstantin Ryabitsev
2020-12-19 12:29   ` Toke Høiland-Jørgensen
2020-12-18 22:38 ` [kernel.org users] " James Bottomley
2020-12-19 12:34   ` Toke Høiland-Jørgensen
2020-12-19 17:03     ` James Bottomley
2020-12-19 17:21       ` Jakub Kicinski
2020-12-19 17:32         ` James Bottomley
2020-12-21 19:05         ` Jason Gunthorpe
2020-12-21 21:13           ` Michal Kubeček
2020-12-21 21:30           ` Arnaldo Carvalho de Melo
2020-12-22  6:30             ` Leon Romanovsky
2020-12-22  8:14               ` Geert Uytterhoeven
2020-12-22 12:36                 ` Leon Romanovsky
2021-01-05 13:38                 ` Jason Gunthorpe
2020-12-19 18:45       ` Jonathan Corbet
2020-12-19 18:49         ` James Bottomley
2020-12-19 18:57           ` Jonathan Corbet
2020-12-19 19:03             ` James Bottomley
2020-12-19 20:48               ` Arnaldo Carvalho de Melo
2020-12-19 21:01                 ` James Bottomley [this message]
2020-12-19 21:43                   ` Arnaldo Carvalho de Melo
2020-12-19 21:57                     ` James Bottomley
2020-12-19 22:17                       ` Arnaldo Carvalho de Melo
2020-12-19 23:34                         ` James Bottomley
2020-12-21 17:34       ` [tools] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e700a8744c3b32070977bf672cd6788e12d6b7d5.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=acme@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=corbet@lwn.net \
    --cc=konstantin@linuxfoundation.org \
    --cc=toke@toke.dk \
    --cc=tools@linux.kernel.org \
    --cc=users@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).