From: Josef Bacik <josef@toxicpanda.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
tools@linux.kernel.org
Cc: kernel-team@fb.com
Subject: Re: [tools] [PATCH] b4: add an --apply option for b4 am
Date: Thu, 10 Sep 2020 10:33:47 -0400 [thread overview]
Message-ID: <f823853e-cc35-7ec3-cf16-fef95be60da6@toxicpanda.com> (raw)
In-Reply-To: <20200909194527.ig2b4ayod7esd2a3@chatter.i7.local>
On 9/9/20 3:45 PM, Konstantin Ryabitsev wrote:
> On Mon, Aug 24, 2020 at 11:43:21AM -0400, Josef Bacik wrote:
>> I'm infinitely lazy and would rather not have to copy and paste the git
>> am command to run. This patch adds a --apply/-a option to git am so
>> it'll go ahead and run git am so I can get to the work of reviewing a
>> patch series.
>
> I've considered this many times, but I thus far prefer not to do it, as
> we generally try not to touch the developer's tree in order to avoid any
> potential badness.
>
> The functionality you want can be easily achieved with "-o- | git am",
> so you can make sure to heed any error messages first without it, and
> then with it:
>
> b4 am <msgid>
> (perform the review)
> b4 am <msgid> -s -l -o- | git am
>
> Would you be willing to use that, or do you think we really need an
> --apply option?
>
Yeah somehow I missed the "-o -" option, I'll just use that. I primarily use b4
for review, so I'm in a scratch branch specifically to apply+build+review the
series I'm pulling, so I don't mind if b4 messes up my current git tree. But
this works just as well, thanks,
Josef
prev parent reply other threads:[~2020-09-10 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 15:43 [PATCH] b4: add an --apply option for b4 am Josef Bacik
2020-09-09 19:45 ` [tools] " Konstantin Ryabitsev
2020-09-10 14:33 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f823853e-cc35-7ec3-cf16-fef95be60da6@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).