archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/>
To: Josh Zimmerman <>,
	Peter Huewe <>,
	Marcel Selhorst <>,
	Jason Gunthorpe
Subject: Re: [PATCH v6 1/2] tpm: Issue a TPM2_Shutdown for TPM2 devices.
Date: Sun, 18 Jun 2017 23:53:55 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 2017-06-16 at 10:25 -0700, Josh Zimmerman wrote:
> If a TPM2 loses power without a TPM2_Shutdown command being issued (a
> "disorderly reboot"), it may lose some state that has yet to be
> persisted to NVRam, and will increment the DA counter. After the DA
> counter gets sufficiently large, the TPM will lock the user out.
> NOTE: This only changes behavior on TPM2 devices. Since TPM1 uses
> and sysfs relies on implicit locking on chip->ops, it is not safe to
> allow this code to run in TPM1, or to add sysfs support to TPM2,
> that locking is made explicit.
> Signed-off-by: Josh Zimmerman <>
> Cc:
> ----
> v2:
>   - Properly split changes between this and another commit
>   - Use proper locking primitive.
>   - Fix commenting style
> v3:
>   - Re-fix commenting style
> v4:
>   - Update description and tags (Reviewed-by, Cc).
> v5:
>   - Update documentation.
> v6:
>   - Call device and/or bus shutdown from tpm_shutdown.

The change log should be after the dashes *below* right before diff
stat. Since this is 1/2 I should be abe to assume that I could apply on
this and not apply 2/2.

Why this patch set does not have a cover letter?

Anyway, I applied these to my master and if they don't break anything
I'm including them to my 4.13 pull request. I left the commit messages
to the form that they turn out if I just git am -3 the mbox files.

Next time, do a git am sanity check if you have changelogs in your


Check out the vibrant tech community on one of the world's most
engaging tech sites,!
tpmdd-devel mailing list

  parent reply	other threads:[~2017-06-18 21:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16 17:25 [PATCH v6 1/2] tpm: Issue a TPM2_Shutdown for TPM2 devices Josh Zimmerman via tpmdd-devel
     [not found] ` <>
2017-06-16 17:25   ` [PATCH v6 2/2] Add "shutdown" to "struct class" Josh Zimmerman via tpmdd-devel
2017-06-18 21:53   ` Jarkko Sakkinen [this message]
2017-06-18 23:21   ` [PATCH v6 1/2] tpm: Issue a TPM2_Shutdown for TPM2 devices Jarkko Sakkinen
     [not found]     ` <1497828091.2552.6.camel-VuQAYsv1563Yd54FQh9/>
2017-06-18 23:26       ` Jarkko Sakkinen
     [not found]         ` <1497828407.2552.8.camel-VuQAYsv1563Yd54FQh9/>
2017-06-19 15:51           ` Jason Gunthorpe
     [not found]             ` <20170619155122.GA10188-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/>
2017-06-19 22:12               ` Jarkko Sakkinen
     [not found]                 ` <20170619221220.kfk5dldducxvou5b-VuQAYsv1563Yd54FQh9/>
2017-06-19 22:21                   ` Jarkko Sakkinen
     [not found]                     ` <20170619222122.55m5goanayw3gkeo-VuQAYsv1563Yd54FQh9/>
2017-06-19 22:38                       ` Jarkko Sakkinen
     [not found]                         ` <20170619223840.a66extf3r5ylmpnb-VuQAYsv1563Yd54FQh9/>
2017-06-19 22:44                           ` Josh Zimmerman via tpmdd-devel
     [not found]                             ` <>
2017-06-20 15:05                               ` Jarkko Sakkinen
     [not found]                                 ` <20170620150541.x5b7vkxyb3w55gjq-VuQAYsv1563Yd54FQh9/>
2017-06-21  7:37                                   ` Jarkko Sakkinen
2017-06-20  8:44                           ` Jarkko Sakkinen
  -- strict thread matches above, loose matches on Subject: below --
2017-06-02 21:55 Josh Zimmerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \
    --to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/ \
    --cc=jmorris-gx6/ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).