From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: tpmdd-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] tpm2: add session handle context saving and restoring to the space code'
Date: Fri, 10 Feb 2017 21:07:27 +0200 [thread overview]
Message-ID: <20170210190727.abaxbbpqq45kb2mm@intel.com> (raw)
In-Reply-To: <1486743078.2502.4.camel@HansenPartnership.com>
On Fri, Feb 10, 2017 at 08:11:18AM -0800, James Bottomley wrote:
> On Fri, 2017-02-10 at 10:52 +0200, Jarkko Sakkinen wrote:
> > On Wed, Feb 08, 2017 at 01:07:08PM +0200, Jarkko Sakkinen wrote:
> > > + rc = tpm2_load_context(chip, space->session_buf,
> > > + &offset, &handle);
> > > + if (rc == -ENOENT) {
> > > + /* load failed, just forget session */
> > > + space->session_tbl[i] = 0;
> >
> > This is my only concern in this commit. Should we also in this case
> > just flush the space or not?
>
> I elected not to. If the handle is flushed by an external resource
> manager, we get this event. If the RM and the app agreed to release
> the session handle, then flushing the space would be overkill because
> it would destroy the client session, so simply removing the handle
> works. If the client tries to use the session again, it gets an error
> and if it doesn't everything just works, which seems to be optimal.
>
> James
Makes sense. Just wanted the check the logic you had in this decision.
/Jarkko
next prev parent reply other threads:[~2017-02-10 19:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 11:07 [PATCH 0/6] in-kernel resource manager Jarkko Sakkinen
[not found] ` <20170208110713.14070-1-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-02-08 11:07 ` [PATCH 1/6] tpm: validate TPM 2.0 commands Jarkko Sakkinen
2017-02-08 11:07 ` [PATCH 2/6] tpm: export tpm2_flush_context_cmd Jarkko Sakkinen
[not found] ` <20170208110713.14070-3-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-02-08 17:58 ` Jason Gunthorpe
[not found] ` <20170208175830.GA31571-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-02-10 7:42 ` Jarkko Sakkinen
2017-02-08 11:07 ` [PATCH 3/6] tpm: infrastructure for TPM spaces Jarkko Sakkinen
[not found] ` <20170208110713.14070-4-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-03-23 15:40 ` [PATCH linux-next] tmp2: fix an off by one bug Vincent Stehlé
[not found] ` <20170323154029.27816-1-vincent.stehle-QFKgK+z4sOrR7s880joybQ@public.gmane.org>
2017-03-23 18:15 ` Jarkko Sakkinen
2017-02-08 11:07 ` [PATCH 4/6] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c Jarkko Sakkinen
2017-02-08 11:07 ` [PATCH 5/6] tpm: expose spaces via a device link /dev/tpms<n> Jarkko Sakkinen
2017-02-08 11:07 ` [PATCH 6/6] tpm2: add session handle context saving and restoring to the space code Jarkko Sakkinen
[not found] ` <20170208110713.14070-7-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-02-10 8:52 ` Jarkko Sakkinen
[not found] ` <20170210085256.eqhnrmdug2fcz4ql-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-02-10 16:11 ` James Bottomley
2017-02-10 19:07 ` Jarkko Sakkinen [this message]
2017-02-10 12:32 ` Jarkko Sakkinen
[not found] ` <20170210123249.nrppoez2kdr2q4nw-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-02-10 16:17 ` James Bottomley
[not found] ` <1486743431.2502.6.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-02-10 19:10 ` Jarkko Sakkinen
[not found] ` <20170210191004.yv5hgnd3h5scj5zt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-02-10 19:12 ` James Bottomley
2017-02-10 22:48 ` [tpmdd-devel] " Jarkko Sakkinen
2017-02-10 8:53 ` [PATCH 0/6] in-kernel resource manager Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210190727.abaxbbpqq45kb2mm@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).