From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v2 2/3] tpm_tis: Use platform_get_irq Date: Tue, 9 May 2017 02:45:39 +0300 Message-ID: <20170508234539.qnhf6p7fwxxcb5ul@intel.com> References: <1493913205-18276-1-git-send-email-jgunthorpe@obsidianresearch.com> <1493913205-18276-3-git-send-email-jgunthorpe@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1493913205-18276-3-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Thu, May 04, 2017 at 09:53:24AM -0600, Jason Gunthorpe wrote: > Replace the open coded IORESOURCE_IRQ with platform_get_irq, which > supports more cases. > > Fixes: 00194826e6be ("tpm_tis: Clean up the force=1 module parameter") > Tested-by: Jerry Snitselaar > Signed-off-by: Jason Gunthorpe Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm_tis.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 56ce2bb1916693..1807b284326b88 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -332,10 +332,8 @@ static int tpm_tis_plat_probe(struct platform_device *pdev) > } > tpm_info.res = *res; > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > - if (res) { > - tpm_info.irq = res->start; > - } else { > + tpm_info.irq = platform_get_irq(pdev, 0); > + if (tpm_info.irq <= 0) { > if (pdev != force_pdev) > tpm_info.irq = -1; > else > -- > 2.7.4 > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot