From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Josh Zimmerman <joshz@google.com>
Cc: linux-kernel@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net
Subject: Re: [PATCH v3] Add "shutdown" to "struct class".
Date: Thu, 25 May 2017 18:41:18 +0200 [thread overview]
Message-ID: <20170525164118.GA28995@kroah.com> (raw)
In-Reply-To: <CAHSjozC4N7ShgCqNPbvycrhe17e3NKVik92Gy0vAHqBvBm-oAA@mail.gmail.com>
On Thu, May 25, 2017 at 09:24:30AM -0700, Josh Zimmerman wrote:
> On Thu, May 25, 2017 at 9:09 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Thu, May 25, 2017 at 08:40:28AM -0700, Josh Zimmerman wrote:
> >> Thanks, Greg.
> >>
> >> Greg, Jarkko: Do either of you you have any objections to me
> >> backporting these changes to 4.4 and 4.9? I'd like to make sure that
> >> at least the couple most recent LTS kernels have this patch.
> >
> > Why? What bug does this solve?
> If a TPM2 device has power removed without a TPM2_Shutdown being
> issued, it will increment its "dictionary attack" counter. After that
> counter reaches a certain value, the TPM2 device will lock the user
> out. Adding the shutdown callback allows the TPM kernel driver to send
> TPM2_Shutdown to all TPM2 devices.
Is all of that in the tpm patch description? If so, great, if not,
please add it.
> > If it meets the rules of
> > Documentation/stable_kernel_rules.txt (or whereever that file moved to),
> > that's fine with me.
> Documentation/process/stable-kernel-rules.rst, right? To comply with
> option 1 referred to there (Adding the appropriate "Cc:" to the
> description), should I send a new patch email or just reply to this
> one and quote the relevant part? (I don't believe the document
> specifies.)
You (or who ever applies these patches) needs to add the cc: stable tag
to them. I suggest resend these, as a patch series, with that in it, so
that it all makes more sense and the tpm maintainer has an easy job of
it.
thanks,
greg k-h
next prev parent reply other threads:[~2017-05-25 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 17:34 [PATCH v3] Add "shutdown" to "struct class" Josh Zimmerman
2017-05-15 17:39 ` Josh Zimmerman
[not found] ` <CAHSjozBLBUpSzxrRsfnO49Thf9__MHdOmUdsX+5ST55=T2BWLA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-15 17:45 ` Jason Gunthorpe
[not found] ` <20170515174533.GB6229-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-15 20:49 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B641D90DB-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-05-18 15:20 ` Josh Zimmerman
[not found] ` <20170515173438.13420-1-joshz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-05-25 13:09 ` Greg Kroah-Hartman
[not found] ` <20170525130930.GA16244-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-05-25 15:40 ` Josh Zimmerman
[not found] ` <CAHSjozAkGo1OnjK8HO3m1YyAwamd4CNZ9rUNiwmBeQz6Gau9VA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-25 16:09 ` Greg Kroah-Hartman
2017-05-25 16:24 ` Josh Zimmerman
2017-05-25 16:41 ` Greg Kroah-Hartman [this message]
[not found] ` <20170525164118.GA28995-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-05-25 22:40 ` Jarkko Sakkinen
2017-05-25 17:06 ` Jarkko Sakkinen
2017-05-25 17:05 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525164118.GA28995@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=joshz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).