From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v6 1/2] tpm: Issue a TPM2_Shutdown for TPM2 devices. Date: Mon, 19 Jun 2017 09:51:22 -0600 Message-ID: <20170619155122.GA10188@obsidianresearch.com> References: <20170616172531.28464-1-joshz@google.com> <1497828091.2552.6.camel@linux.intel.com> <1497828407.2552.8.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1497828407.2552.8.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Jun 19, 2017 at 01:26:47AM +0200, Jarkko Sakkinen wrote: > Feels weird that you have to call framework functions like that in the > driver. You must have brilliant reason to do so and that should be very > well documented in the code. This is terrible... This was all discussed on the list. It the way these callbacks work, the higher levels in the callback stack call the lower levels, this allows each level the place the next level's callback properly, eg do things before/after as necessary. Jason ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot