tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Josh Zimmerman <joshz@google.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	tpmdd-devel@lists.sourceforge.net, stable@vger.kernel.org
Subject: Re: [PATCH v1 4/4] tpm: Issue a TPM2_Shutdown for TPM2 devices.
Date: Tue, 18 Jul 2017 18:29:05 +0200	[thread overview]
Message-ID: <20170718162905.GA4809@kroah.com> (raw)
In-Reply-To: <CAHSjozBE-=aCZoBvuHanPWYQKhY3Lj5YTNnnA65Q-GgZ2y1iSQ@mail.gmail.com>

On Tue, Jul 18, 2017 at 09:11:49AM -0700, Josh Zimmerman wrote:
> On Tue, Jul 18, 2017 at 8:49 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Jul 14, 2017 at 12:58:03PM -0700, Josh Zimmerman wrote:
> >> Backport of d1bd4a792d3961a04e6154118816b00167aad91a upstream.
> >>
> >> If a TPM2 loses power without a TPM2_Shutdown command being issued (a
> >> "disorderly reboot"), it may lose some state that has yet to be
> >> persisted to NVRam, and will increment the DA counter. After the DA
> >> counter gets sufficiently large, the TPM will lock the user out.
> >>
> >> NOTE: This only changes behavior on TPM2 devices. Since TPM1 uses sysfs,
> >> and sysfs relies on implicit locking on chip->ops, it is not safe to
> >> allow this code to run in TPM1, or to add sysfs support to TPM2, until
> >> that locking is made explicit.
> >> ---
> >>  drivers/char/tpm/tpm-chip.c  | 36 ++++++++++++++++++++++++++++++++++++
> >>  drivers/char/tpm/tpm-sysfs.c |  7 +++++++
> >>  2 files changed, 43 insertions(+)
> >>
> >
> > Again no signed-off-by :(
> 
> Oops, sorry about that.
> 
> Did you pull in the two cherry-picks as well? They're needed for these
> two to build and merge cleanly.
> 
> I can send a v2 if you need with a corrected signed-off-by and correct
> number of patches in the cover letter.

I should have them all now, and you should have gotten emails about
it...

thanks,

greg k-h

  reply	other threads:[~2017-07-18 16:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-14 19:57 [PATCH v1 0/2] Run TPM2_Shutdown on system shutdown Josh Zimmerman
2017-07-14 19:58 ` [PATCH v1 1/4] tpm: Get rid of chip->pdev Josh Zimmerman
2017-07-14 19:58 ` [PATCH v1 2/4] tpm: Provide strong locking for device removal Josh Zimmerman
2017-07-14 19:58 ` [PATCH v1 3/4] Add "shutdown" to "struct class".' Josh Zimmerman
2017-07-18 15:48   ` Greg KH
2017-07-14 19:58 ` [PATCH v1 4/4] tpm: Issue a TPM2_Shutdown for TPM2 devices Josh Zimmerman
2017-07-18 15:49   ` Greg KH
2017-07-18 16:11     ` Josh Zimmerman
2017-07-18 16:29       ` Greg KH [this message]
2017-07-18 16:33         ` Josh Zimmerman
2017-07-18 15:50 ` [PATCH v1 0/2] Run TPM2_Shutdown on system shutdown Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718162905.GA4809@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=joshz@google.com \
    --cc=stable@vger.kernel.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --subject='Re: [PATCH v1 4/4] tpm: Issue a TPM2_Shutdown for TPM2 devices.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).