From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: SZ Lin <sz.lin@moxa.com>
Cc: ashleydlai@gmail.com, benh@kernel.crashing.org, paulus@samba.org,
mpe@ellerman.id.au, peterhuewe@gmx.de, tpmdd@selhorst.ne,
jgunthorpe@obsidianresearch.com,
tpmdd-devel@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] tpm: tpm_ibmvtpm: - style fix
Date: Wed, 2 Aug 2017 15:36:19 +0300 [thread overview]
Message-ID: <20170802123619.nhmwexzaybck3lif@linux.intel.com> (raw)
In-Reply-To: <20170729072433.13194-1-sz.lin@moxa.com>
On Sat, Jul 29, 2017 at 03:24:28PM +0800, SZ Lin wrote:
> Fix styling WARNINGs and Errors of tpm_ibmvtpm.c driver by using checkpatch.pl
Changes are great but you should revise the patch series so that you
expain in each commit what goes wrong instead of copy paste of the
checkpatch output and why your changes fixes the problem.
>
> SZ Lin (5):
> Fix packed and aligned attribute warnings.
> Fix "ERROR: code indent should use tabs where possible"
> Fix 'void function return statements are not generally useful' warning
> Remove unneccessary 'out of memory' message
> Use __func__ instead of function name
>
> drivers/char/tpm/tpm_ibmvtpm.c | 23 +++++++++--------------
> drivers/char/tpm/tpm_ibmvtpm.h | 2 +-
> 2 files changed, 10 insertions(+), 15 deletions(-)
>
> --
> 2.13.3
>
/Jarkko
prev parent reply other threads:[~2017-08-02 12:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 7:24 SZ Lin
2017-02-24 19:35 ` [RFT PATCH] tpm: ibmvtpm: simplify crq initialization and document crq format Michal Suchanek
2017-08-17 22:21 ` msuchanek
2017-08-19 17:18 ` Jarkko Sakkinen
2017-08-19 17:24 ` Jarkko Sakkinen
2017-07-29 7:24 ` [PATCH 1/5] Fix packed and aligned attribute warnings SZ Lin
2017-07-31 13:27 ` David Laight
2017-07-29 7:24 ` [PATCH 2/5] Fix "ERROR: code indent should use tabs where possible" SZ Lin
2017-07-31 10:25 ` Michael Ellerman
2017-07-29 7:24 ` [PATCH 3/5] Fix 'void function return statements are not generally useful' warning SZ Lin
2017-07-29 7:24 ` [PATCH 4/5] Remove unneccessary 'out of memory' message SZ Lin
2017-07-29 7:24 ` [PATCH 5/5] Use __func__ instead of function name SZ Lin
[not found] ` <20170729072433.13194-6-sz.lin-D4fb9hXD9d4@public.gmane.org>
2017-08-18 8:03 ` Michal Suchánek
[not found] ` <0e2d9ac4f5ee02e9df98610ed07eaec9-l3A5Bk7waGM@public.gmane.org>
2017-08-18 11:25 ` Michael Ellerman
2017-08-19 7:58 ` 김동현
2017-08-02 12:36 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802123619.nhmwexzaybck3lif@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ashleydlai@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterhuewe@gmx.de \
--cc=sz.lin@moxa.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.ne \
--subject='Re: [PATCH 0/5] tpm: tpm_ibmvtpm: - style fix' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).