From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Hamza Attak <hamza@hpe.com>
Cc: tpmdd-devel@lists.sourceforge.net, nigel.edwards@hpe.com,
ludo@hpe.com, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2] msleep() delays - replace with usleep_range() in TPM 1.2/2.0 generic drivers
Date: Sat, 19 Aug 2017 15:16:20 +0300 [thread overview]
Message-ID: <20170819121620.4zxnvz5ki76jbbe4@linux.intel.com> (raw)
In-Reply-To: <20170814180916.GA5574@dev-HP-EliteBook-Folio-1040-G1>
On Mon, Aug 14, 2017 at 07:09:16PM +0100, Hamza Attak wrote:
> The patch simply replaces all msleep function calls with usleep_range calls
> in the generic drivers.
>
> Tested with an Infineon TPM 1.2, using the generic tpm-tis module, for a
> thousand PCR extends, we see results going from 1m57s unpatched to 40s
> with the new patch. We obtain similar results when using the original and
> patched tpm_infineon driver, which is also part of the patch.
> Similarly with a STM TPM 2.0, using the CRB driver, it takes about 20ms per
> extend unpatched and around 7ms with the new patch.
>
> Note that the PCR consistency is untouched with this patch, each TPM has
> been tested with 10 million extends and the aggregated PCR value is
> continuously verified to be correct.
>
> As an extension of this work, this could potentially and easily be applied
> to other vendor's drivers. Still, these changes are not included in the
> proposed patch as they are untested.
>
> Signed-off-by: Hamza Attak <hamza@hpe.com>
Applying this.
Tested-by: Jarkko Sakkine <jarkko.sakkinen@linux.intel.com>
PS. Your short summary is broken. See how I fixed it. Otherwise,
no complains.
/Jarkko
prev parent reply other threads:[~2017-08-19 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 18:09 [PATCH v2] msleep() delays - replace with usleep_range() in TPM 1.2/2.0 generic drivers Hamza Attak
2017-08-15 6:10 ` Jarkko Sakkinen
2017-08-19 12:16 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170819121620.4zxnvz5ki76jbbe4@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=hamza@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=ludo@hpe.com \
--cc=nigel.edwards@hpe.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).