From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 1/3] tpm2-cmd: Trigger only missing self tests Date: Sat, 19 Aug 2017 20:16:02 +0300 Message-ID: <20170819171602.6lrr4zdjwju4oq73@linux.intel.com> References: <20170818121532.5764-1-Alexander.Steffen@infineon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170818121532.5764-1-Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Alexander Steffen Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Aug 18, 2017 at 02:15:30PM +0200, Alexander Steffen wrote: > tpm2_do_selftest is only used during initialization of the TPM to ensure > that the device functions correctly. Therefore, it is sufficient to request > only missing self tests (parameter full_test=0), not a reexecution of all > self tests, as was done before. This allows for a faster execution of this > command. > > Signed-off-by: Alexander Steffen Where is the cover letter? /Jarkko > --- > drivers/char/tpm/tpm2-cmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c > index f7f34b2a..7e328d6 100644 > --- a/drivers/char/tpm/tpm2-cmd.c > +++ b/drivers/char/tpm/tpm2-cmd.c > @@ -865,7 +865,7 @@ static int tpm2_start_selftest(struct tpm_chip *chip, bool full) > } > > /** > - * tpm2_do_selftest() - run a full self test > + * tpm2_do_selftest() - ensure that all self tests have passed > * > * @chip: TPM chip to use > * > @@ -886,7 +886,7 @@ static int tpm2_do_selftest(struct tpm_chip *chip) > > loops = jiffies_to_msecs(duration) / delay_msec; > > - rc = tpm2_start_selftest(chip, true); > + rc = tpm2_start_selftest(chip, false); > if (rc) > return rc; > > -- > 2.7.4 > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot