From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jiandi An <anjiandi@codeaurora.org>
Cc: peterhuewe@gmx.de, tpmdd@selhorst.net,
jgunthorpe@obsidianresearch.com,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm/tpm_crb: Access locality for non-ACPI and non-SMC start method
Date: Tue, 22 Aug 2017 20:36:49 +0300 [thread overview]
Message-ID: <20170822173649.qnvtt6jxhwaa6zye@linux.intel.com> (raw)
In-Reply-To: <424ce770-e21b-749c-df5c-b12a2691269e@codeaurora.org>
On Sun, Aug 20, 2017 at 10:41:38PM -0500, Jiandi An wrote:
>
>
> On 08/19/2017 12:05 PM, Jarkko Sakkinen wrote:
> > On Thu, Aug 17, 2017 at 11:15:36PM -0500, Jiandi An wrote:
> > > For ARM64, the locality is handled by Trust Zone in FW.
> > > The layout does not have crb_regs_head. It is hitting
> > > the following line.
> > > dev_warn(dev, FW_BUG "Bad ACPI memory layout");
> > >
> > > Current code excludes CRB_FL_ACPI_START and when
> > > CRB_FL_CRB_SMC_START is added around the same time
> > > locality support is added, it should also be excluded.
> > >
> > > For goIdle and cmdReady where code was excluding
> > > CRB_FL_ACPI_START only (do nothing for ACPI start method),
> > > CRB_FL_CRB_SMC_START was also excluded as ARM64 SMC start
> > > method does not have TPM_CRB_CTRL_REQ.
> > > Change if confition to white list instead of black list.
> > >
> > > Signed-off-by: Jiandi An <anjiandi@codeaurora.org>
> >
> > Is this v2? If so, where is the change log?
> Based on the previous comments, I now understand that
> because of Intel PTT bug workaround, it is not appropriate
> for the patch to have title/subject "Access locality for
> only CRB_START method"
>
> So the more descriptive patch title is "Access locality for
> only non-ACPI and non-SMC start method". Because the patch
> is changed, I thought I start a new series. Would you like
> me to tag this v3 and put change log even though patch title
> has changed?
>
> Thanks
> - Jiandi
I see. Thanks for explaining.
/Jarkko
next prev parent reply other threads:[~2017-08-22 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 4:15 [PATCH] tpm/tpm_crb: Access locality for non-ACPI and non-SMC start method Jiandi An
2017-08-19 17:05 ` Jarkko Sakkinen
2017-08-21 3:41 ` Jiandi An
2017-08-22 17:36 ` Jarkko Sakkinen [this message]
2017-08-22 17:39 ` Jarkko Sakkinen
2017-08-22 21:28 ` Jiandi An
[not found] ` <d88e255c-f8c9-b6fc-64bd-8cf56153fcce-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-08-23 2:25 ` Jason Gunthorpe
2017-08-24 12:26 ` Jarkko Sakkinen
2017-08-24 17:20 ` Jiandi An
2017-08-25 16:21 ` Jarkko Sakkinen
2017-08-25 16:53 ` Jason Gunthorpe
2017-08-25 17:28 ` Jiandi An
2017-08-25 17:35 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822173649.qnvtt6jxhwaa6zye@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=anjiandi@codeaurora.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).