archive mirror
 help / color / mirror / Atom feed
From: Alexander Steffen <Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/>
To: jarkko.sakkinen-VuQAYsv1563Yd54FQh9/,
Subject: [PATCH v2 1/3] tpm2-cmd: Trigger only missing self tests
Date: Thu, 24 Aug 2017 10:30:04 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20170824083006.7704-1-Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/>

tpm2_do_selftest is only used during initialization of the TPM to ensure
that the device functions correctly. Therefore, it is sufficient to request
only missing self tests (parameter full_test=0), not a reexecution of all
self tests, as was done before. This allows for a faster execution of this

Signed-off-by: Alexander Steffen <Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/>
 drivers/char/tpm/tpm2-cmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
index e1a41b7..8e940a5 100644
--- a/drivers/char/tpm/tpm2-cmd.c
+++ b/drivers/char/tpm/tpm2-cmd.c
@@ -865,7 +865,7 @@ static int tpm2_start_selftest(struct tpm_chip *chip, bool full)
- * tpm2_do_selftest() - run a full self test
+ * tpm2_do_selftest() - ensure that all self tests have passed
  * @chip: TPM chip to use
@@ -886,7 +886,7 @@ static int tpm2_do_selftest(struct tpm_chip *chip)
 	loops = jiffies_to_msecs(duration) / delay_msec;
-	rc = tpm2_start_selftest(chip, true);
+	rc = tpm2_start_selftest(chip, false);
 	if (rc)
 		return rc;

Check out the vibrant tech community on one of the world's most
engaging tech sites,!

  parent reply	other threads:[~2017-08-24  8:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24  8:30 [PATCH v2 0/3] tpm2-cmd: Improve self test execution Alexander Steffen
     [not found] ` <20170824083006.7704-1-Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/>
2017-08-24  8:30   ` Alexander Steffen [this message]
2017-08-24  8:34   ` [PATCH v2 2/3] tpm2-cmd: Use dynamic delay to wait for self test result Alexander Steffen
     [not found]     ` <20170824083410.6964-1-Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/>
2017-08-24  8:34       ` [PATCH v2 3/3] tpm2-cmd: React correctly to RC_TESTING from self tests Alexander Steffen
     [not found]         ` <20170824083410.6964-2-Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/>
2017-08-24 12:46           ` Jarkko Sakkinen
2017-08-26 11:23   ` [PATCH v2 0/3] tpm2-cmd: Improve self test execution Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \
    --to=alexander.steffen-d0qzbvysippwk0htik3j/ \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).