tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net,
	LSM List <linux-security-module@vger.kernel.org>,
	jgunthorpe@obsidianresearch.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] tpm: vtpm_proxy: Add ioctl to request locality prepended to command
Date: Wed, 10 May 2017 09:20:14 -0400	[thread overview]
Message-ID: <2c20fc62-938a-a6da-dbb2-70711b84996d@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170510124745.lmqvonrkjmjes7ep@intel.com>

On 05/10/2017 08:47 AM, Jarkko Sakkinen wrote:
> On Tue, May 09, 2017 at 11:49:05AM -0400, Stefan Berger wrote:
>> On 05/08/2017 07:43 PM, Jarkko Sakkinen wrote:
>>> On Thu, May 04, 2017 at 04:03:18PM -0400, Stefan Berger wrote:
>>>> On 05/04/2017 02:40 PM, Jarkko Sakkinen wrote:
>>>>> On Thu, May 04, 2017 at 07:14:27AM -0400, Stefan Berger wrote:
>>>>>> On 05/04/2017 05:17 AM, Jarkko Sakkinen wrote:
>>>>>>> On Wed, May 03, 2017 at 07:40:48PM -0400, Stefan Berger wrote:
>>>>>>>> On 05/03/2017 06:37 PM, Jarkko Sakkinen wrote:
>>>>>>>>> On Fri, Apr 28, 2017 at 09:02:18AM -0400, Stefan Berger wrote:
>>>>>>>>>> Add an ioctl to request that the locality be prepended to every TPM
>>>>>>>>>> command.
>>>>>>>>> Don't really understand this change. Why locality is prenpended?
>>>>>>>> Commands can be executed under locality 0-3 and for some commands it is
>>>>>>>> important to know which locality a user may have chosen. How else should we
>>>>>>>> convey that locality to the TPM emulator ?
>>>>>>> Why this is not in the commit message?
>>>>>>>
>>>>>>> More scalable way to do this would be to have a set of vtpm proxy
>>>>>>> commands. There could be a command for requesting and releasing
>>>>>>> locality. That would be more clean.
>>>>>> I would think that if someone wanted to use locality it's the client using
>>>>>> /dev/tpm(rm)0 calling an ioctl or so and the vtpm proxy then merely passing
>>>>>> that locality to the backend (TPM emulator). I suppose the intention is to
>>>>>> support something like that following the addition of the new functions
>>>>>> request_locality and release_locality?
>>>>> What if we later on want to pass something else than locality to the
>>>>> backend? How that will work out?
>>>> 'push' more data in front. 'pop' off by recipient. We could wrap the command
>>>> in some form.
>>>>
>>>>       Stefan
>>> I would find having a set of special commands cleaner. Prepending sounds
>>> like a quick hack to me, not really something that should exist in the
>>> mainline.
>> Along the lines of this here?
>>
>> uint32_2 command
>> uint32_2 totlength
>> uint8_t locality
>> uint8_t buffer[]  <- the actual TPM command
>>
>>
>> With a command code like VTPM_PROXY_CMD_TPM_CMD = 1.
>>
>>     Stefan
> That would break binary compability.

That's why I am adding that additional flag that allows a client to 
choose whether it wants the TPM command wrapped (or locality prepended) 
so that it knows what to expect from the driver. I don't think that 
breaks compatibility.

>
> I would suggest allocating CC's backwards starting from 0xFFFFFFFF for
> these control messages and send them in regular TPM command layout. A
> bit similar idea as we have in the RM.
>
> /Jarkko
>


  reply	other threads:[~2017-05-10 13:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-28 13:02 [PATCH v2 0/3] Extend the vTPM proxy driver to pass locality to emulator Stefan Berger
     [not found] ` <1493384538-27883-1-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-04-28 13:02   ` [PATCH v2 1/3] tpm: vtpm_proxy: Add ioctl to get supported flags Stefan Berger
2017-05-03 22:31     ` Jarkko Sakkinen
2017-04-28 13:02   ` [PATCH v2 2/3] tpm: vtpm_proxy: Implement request_locality Stefan Berger
2017-04-29 11:58   ` [PATCH v2 0/3] Extend the vTPM proxy driver to pass locality to emulator Jarkko Sakkinen
2017-04-28 13:02 ` [PATCH v2 3/3] tpm: vtpm_proxy: Add ioctl to request locality prepended to command Stefan Berger
     [not found]   ` <1493384538-27883-4-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-04-29  7:02     ` kbuild test robot
2017-05-03 22:37   ` Jarkko Sakkinen
     [not found]     ` <20170503223747.zefh76m4youqlgje-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-05-03 23:40       ` Stefan Berger
     [not found]         ` <40cd7d48-f6d1-39f4-99a3-916c7cdbb636-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-04  9:17           ` Jarkko Sakkinen
2017-05-04 11:14             ` Stefan Berger
2017-05-04 18:40               ` Jarkko Sakkinen
     [not found]                 ` <20170504184007.46efvqyqwxjkzwuq-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-05-04 20:03                   ` Stefan Berger
2017-05-08 23:43                     ` Jarkko Sakkinen
     [not found]                       ` <20170508234328.iydmoverh5z4nwco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-05-09 15:49                         ` Stefan Berger
2017-05-10 12:47                           ` Jarkko Sakkinen
2017-05-10 13:20                             ` Stefan Berger [this message]
     [not found]                               ` <2c20fc62-938a-a6da-dbb2-70711b84996d-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-10 18:33                                 ` Jarkko Sakkinen
2017-05-03 22:38 ` [PATCH v2 0/3] Extend the vTPM proxy driver to pass locality to emulator Jarkko Sakkinen
2017-05-03 23:42   ` Stefan Berger
     [not found]     ` <72bacff5-5213-b114-ebf4-6e3fe7284bdc-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-04  9:18       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c20fc62-938a-a6da-dbb2-70711b84996d@linux.vnet.ibm.com \
    --to=stefanb@linux.vnet.ibm.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).