tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Georges Savoundararadj <gsavoundararadj-svHpOmPGTvqcqzYg7KEe8g@public.gmane.org>
To: Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: About the SLB9670 TPM 2.0 driver status
Date: Wed, 26 Apr 2017 11:47:51 -0700	[thread overview]
Message-ID: <39067149-b6e1-04e2-7677-5dc054475140@witekio.us> (raw)
In-Reply-To: <a5616ca471a64e5ab4809a231966987b-nFblLGNE8XKJSz+rYg/bSJowlv4uC7bZ@public.gmane.org>

Hi Alexander,


On 04/26/2017 09:04 AM, Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org wrote:
>> I am working with on Infineon SLB9670 TPM 2.0 on SPI.
>>
>> How well is this chip supported in the mainline kernel?
> Unfortunately, due to some small bugs, tpm_tis_spi in mainline is not yet compatible with this device. Starting with 4.12 it should be properly supported.
Sounds good!
>
>> I am currently using the linux-socfpga kernel (version 4.8.0; branch
>> socfpga-4.8) [1]
>> on which I applied the following patches from patchwork:
>>
>> aacabbe0d5ec tpm_tis_spi: Add small delay after last transfer [2]
>> a4a011be786f tpm_tis_spi: Remove limitation of transfers to
>> MAX_SPI_FRAMESIZE bytes [3]
>> 840157e08b2f tpm_tis_spi: Check correct byte for wait state indicator [4]
>> 10cb31aec536 tpm_tis_spi: Abort transfer when too many wait states are
>> signaled [5]
>> 3ad7d9172a8c tpm_tis_spi: Use single function to transfer data [6]
>> 4a809ec34a0f tpm_tis_core: Choose appropriate timeout for reading
>> burstcount [7]
>>
>> With these patches, I can read the Vendor ID properly.
> Those are all the patches that I needed on a Raspberry Pi 2 for the device to work correctly. I did not use 4.8 though, but worked with 4.10.
>
>> But, the driver initialization fails in the tpm2_probe function.
> Could you be more specific? What exactly fails? What data is transferred to/from the TPM when it fails?
I tried again on the 4.11-rc8 kernel with the latest patches from 
linux-tpmdd to be integrated in 4.12 (between tpmdd-next-20170220 and 
tpmdd-next-20170425) and I got the same failure.

The following function calls fails
* tpm2_probe
** tpm_transmit_cmd
*** tpm_transmit
**** chips->ops->send/tpm_tis_send
***** tpm_tis_send_main
****** tpm_tis_send_data

tpm_tis_send_data fails at this moment when it checks the status:

     status = tpm_tis_status(chip);
     if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) {
         rc = -EIO;
         goto out_err;
     }

The data transferred is the command defined in the tpm2_probe function.

Thanks,

Georges
>
> Alexander


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

  parent reply	other threads:[~2017-04-26 18:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26  2:12 About the SLB9670 TPM 2.0 driver status Georges Savoundararadj
     [not found] ` <e7ee0491-3f29-5578-7cc4-af9c0a73dcb3-svHpOmPGTvqcqzYg7KEe8g@public.gmane.org>
2017-04-26 10:37   ` Jarkko Sakkinen
2017-04-26 16:04   ` Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w
     [not found]     ` <a5616ca471a64e5ab4809a231966987b-nFblLGNE8XKJSz+rYg/bSJowlv4uC7bZ@public.gmane.org>
2017-04-26 18:47       ` Georges Savoundararadj [this message]
     [not found]         ` <39067149-b6e1-04e2-7677-5dc054475140-svHpOmPGTvqcqzYg7KEe8g@public.gmane.org>
2017-04-27 15:40           ` Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w
     [not found]             ` <4b9a97a8d4164d0b9fa8d8c99618b7fc-nFblLGNE8XKJSz+rYg/bSJowlv4uC7bZ@public.gmane.org>
2017-04-27 23:36               ` Georges Savoundararadj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39067149-b6e1-04e2-7677-5dc054475140@witekio.us \
    --to=gsavoundararadj-svhpompgtvqcqzyg7kee8g@public.gmane.org \
    --cc=Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).