archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <>
To: Jason Gunthorpe <>
Subject: Re: [PATCH v3 1/3] tpm: vtpm_proxy: Implement new ioctl to get supported flags
Date: Thu, 4 May 2017 13:13:18 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 05/04/2017 11:34 AM, Jason Gunthorpe wrote:
> On Thu, May 04, 2017 at 10:56:25AM -0400, Stefan Berger wrote:
>> Implement VTPM_PROXY_IOC_GET_SUPT_FLAGS ioctl to get the bitmask
>> of flags that the vtpm_proxy driver supports in the
>> VTPM_PROXY_IOC_NEW_DEV ioctl. This helps user space in deciding
>> which flags to set in that ioctl.
> you might be better off just having a VTPM_PROXY_IO_ENABLE_FEATURE
> .feature = LOCALITY

Do you have an example driver that shows how to do this ? Can user space 
query that feature?

> If that fails then the feature is not supported, no real need for the
> query in that case.
> Not sure about Jarkko's point on request/release locality.. Is there a
> scenario where the emulator should fail the request locality?

We could filter localities 5 and higher on the level of the driver 
(patch 2/3) since basically there are only 5 localities (0-4) in any TPM 
interface today. The typical hardware locality 4 would be filtered by 
the emulator per policy passed via command line, but I would allow it on 
the level of this driver. An error message would be returned for any 
command executed in that locality, unless the 'policy' allows it. 
Localities 0-3 should just be selectable. The TPM TIS (in the hardware) 
implements some complicated scheme when it comes to allowing the 
selection of a locality and I would say we need none of that but just 
tell the vTPM proxy driver the locality (patch 2/3) in which the next 
command will be executed.

> Jason

  reply	other threads:[~2017-05-04 17:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 14:56 [PATCH v3 0/3] Extend the vTPM proxy driver to pass locality Stefan Berger
     [not found] ` <>
2017-05-04 14:56   ` [PATCH v3 1/3] tpm: vtpm_proxy: Implement new ioctl to get supported flags Stefan Berger
     [not found]     ` <>
2017-05-04 15:34       ` Jason Gunthorpe
2017-05-04 17:13         ` Stefan Berger [this message]
2017-05-04 17:20           ` Jason Gunthorpe
2017-05-04 17:28             ` Stefan Berger
2017-05-04 17:31               ` Jason Gunthorpe
2017-05-04 17:33                 ` Stefan Berger
2017-05-04 14:56   ` [PATCH v3 2/3] tpm: vtpm_proxy: Implement request_locality function Stefan Berger
2017-05-04 14:56 ` [PATCH v3 3/3] tpm: vtpm_proxy: Add flag for ioctl to request locality prepended to command Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).