From: "Shaikh, Azhar" <azhar.shaikh@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: "jgunthorpe@obsidianresearch.com"
<jgunthorpe@obsidianresearch.com>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>
Subject: RE: [PATCH v6 0/2] Fix corner cases with disabling CLKRUN in tpm_tis
Date: Thu, 30 Nov 2017 18:37:23 +0000 [thread overview]
Message-ID: <5FFFAD06ADE1CA4381B3F0F7C6AF582897061B@ORSMSX109.amr.corp.intel.com> (raw)
In-Reply-To: <20171130163516.uazhkglg7yfzpuvo@linux.intel.com>
>-----Original Message-----
>From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com]
>Sent: Thursday, November 30, 2017 8:35 AM
>To: Shaikh, Azhar <azhar.shaikh@intel.com>
>Cc: jgunthorpe@obsidianresearch.com; peterhuewe@gmx.de; linux-security-
>module@vger.kernel.org; linux-kernel@vger.kernel.org; tpmdd-
>devel@lists.sourceforge.net
>Subject: Re: [PATCH v6 0/2] Fix corner cases with disabling CLKRUN in tpm_tis
>
>On Wed, Nov 29, 2017 at 10:39:49AM -0800, Azhar Shaikh wrote:
>> Changes from v1:
>> - Patch 1: "tpm: Keep CLKRUN enabled throughout the duration of
>transmit_cmd()"
>> - Add NULL checks before calling clk_toggle callback
>> - Use IS_ENABLED instead of ifdef in tpm_tis_clkrun_toggle()
>> - Do not call tpm_platform_begin_xfer() and tpm_platform_end_xfer()
>> from tpm_tis_clkrun_toggle(). Make them static again.
>>
>> - Patch 2: "tpm_tis: Move ilb_base_addr to tpm_tis_tcg_phy"
>> - This is a new patch in this series as per suggestion from Jason.
>> - Is the current implementation ok or I should move the code in
>tpm_tis_pnp_remove()
>> and tpm_tis_plat_remove() inside tpm_tis_remove(). That way all the
>unmapping
>> can be done in one place, instead of 3 different places now. Also the
>unmapping
>> in tpm_tis_init() can be moved to tpm_tis_remove(), since in case of error
>> tpm_tis_core_init() calls tpm_tis_remove(). Kindly suggest.
>>
>> Changes from v2:
>> - Patch 1: "tpm: Keep CLKRUN enabled throughout the duration of
>transmit_cmd()"
>> - No changes
>>
>> - Patch 2: "tpm_tis: Move ilb_base_addr to tpm_tis_tcg_phy"
>> - Updated is_bsw() function to have the #ifdef CONFIG_X86 check within
>the function
>> itself. Also removed the #ifdef CONFIG_X86 from all other places
>> around is_bsw()
>>
>> Changes from v3:
>> - Patch 1: "tpm: Keep CLKRUN enabled throughout the duration of
>transmit_cmd()"
>> - Change function name from clk_toggle to clk_enable
>> - Update the commit message.
>>
>> - Patch 2: "tpm_tis: Move ilb_base_addr to tpm_tis_tcg_phy"
>> - No changes
>>
>> Changes from v4:
>> - The numbering of patches is now interchanged.
>>
>> - Patch 1: "tpm_tis: Move ilb_base_addr to tpm_tis_data"
>> - Had to move ilb_base_addr to tpm_tis_data, from tpm_tis_tcg_phy.
>> Since the ioremapping of ilb_base_addr had to be done before any TPM
>access,
>> hence moved the variable to tpm_tis_data.
>> - Also move the ioremapping of ilb_base_addr from tpm_tis_init() to
>> tpm_tis_core_init() i.e. before any TPM access is done.
>> - Rename marco LPC_CNTRL_REG_OFFSET to LPC_CNTRL_OFFSET
>> - Update the commit message.
>>
>> - Patch 2: "tpm: Keep CLKRUN enabled throughout the duration of
>transmit_cmd()"
>> - Remove the functions tpm_platform_begin_xfer() and
>tpm_platform_end_xfer()
>> - Move the code from these functions to tpm_tis_clkrun_enable().
>>
>> Changes from v5:
>> - Patch 1: "tpm_tis: Move ilb_base_addr to tpm_tis_data"
>> - No changes
>>
>> - Patch 2: "tpm: Keep CLKRUN enabled throughout the duration of
>transmit_cmd()"
>> - Update the commit message.
>>
>> Azhar Shaikh (2):
>> tpm_tis: Move ilb_base_addr to tpm_tis_data
>> tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()
>>
>> drivers/char/tpm/tpm-interface.c | 6 ++
>> drivers/char/tpm/tpm_tis.c | 121 ++++++---------------------------------
>> drivers/char/tpm/tpm_tis_core.c | 111
>> +++++++++++++++++++++++++++++++++--
>> drivers/char/tpm/tpm_tis_core.h | 17 ++++++
>> include/linux/tpm.h | 1 +
>> 5 files changed, 147 insertions(+), 109 deletions(-)
>>
>> --
>> 1.9.1
>
>I'll go through this next week and test with SPI based TPM that it doesn't break
>anything.
>
Sure!
Thank you!
>/Jarkko
Regards,
Azhar Shaikh
next prev parent reply other threads:[~2017-11-30 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 18:39 [PATCH v6 0/2] Fix corner cases with disabling CLKRUN in tpm_tis Azhar Shaikh
2017-11-29 18:39 ` [PATCH v6 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data Azhar Shaikh
2017-11-29 18:39 ` [PATCH v6 2/2] tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd() Azhar Shaikh
2017-11-30 16:35 ` [PATCH v6 0/2] Fix corner cases with disabling CLKRUN in tpm_tis Jarkko Sakkinen
2017-11-30 18:37 ` Shaikh, Azhar [this message]
2017-12-07 1:30 ` Jarkko Sakkinen
2017-12-07 1:35 ` Shaikh, Azhar
2017-12-07 1:38 Azhar Shaikh
2017-12-08 10:51 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5FFFAD06ADE1CA4381B3F0F7C6AF582897061B@ORSMSX109.amr.corp.intel.com \
--to=azhar.shaikh@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).