From: Javier Martinez Canillas <javierm@redhat.com>
To: Thiebaud Weksteen <tweek@google.com>, linux-efi@vger.kernel.org
Cc: ard.biesheuvel@linaro.org, matt@codeblueprint.co.uk,
linux-kernel@vger.kernel.org, mjg59@google.com,
jgunthorpe@obsidianresearch.com,
tpmdd-devel@lists.sourceforge.net,
jarkko.sakkinen@linux.intel.com, Peter Jones <pjones@redhat.com>
Subject: Re: [tpmdd-devel] [PATCH v2 0/3] Call GetEventLog before ExitBootServices
Date: Thu, 14 Sep 2017 12:21:59 +0200 [thread overview]
Message-ID: <5d530df3-7a7a-4cd7-bde6-92f733c7ae75@redhat.com> (raw)
In-Reply-To: <20170911100022.7251-1-tweek@google.com>
Hello Thiebaud,
On 09/11/2017 12:00 PM, Thiebaud Weksteen via tpmdd-devel wrote:
> With TPM 1.2, the ACPI table ("TCPA") has two fields to recover the Event Log
> Area (LAML and LASA). These logs are useful to understand and rebuild the
> final values of PCRs.
>
> With TPM 2.0, the ACPI table ("TPM2") does not contain these fields anymore.
> The recommended method is now to call the GetEventLog EFI protocol before
> ExitBootServices.
>
> Implement this method within the EFI stub and create copy of the logs for the
> TPM device. This will create /sys/kernel/security/tpm0/binary_bios_measurements
> for TPM 2.0 devices (similarly to the current behaviour for TPM 1.2 devices).
>
I've tested your patches on a system with an Intel PTT firmware based TPM2.0 and
the measurements securityfs entry was correctly created and was able to read it:
$ cat /sys/class/tpm/tpm0/device/description
TPM 2.0 Device
$ hexdump /sys/kernel/security/tpm0/binary_bios_measurements | head -n2
0000000 0000 0000 0008 0000 f504 15a0 1810 bf44
0000010 63d0 4fdb b8a4 f278 8dc7 c8aa 0014 0000
So please feel free to add:
Tested-by: Javier Martinez Canillas <javierm@redhat.com>
I also reviewed the patches and look good to me, I have just one question for
patch #2, but I'll comment there.
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
prev parent reply other threads:[~2017-09-14 10:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 10:00 [PATCH v2 0/3] Call GetEventLog before ExitBootServices Thiebaud Weksteen
2017-09-11 10:00 ` [PATCH v2 1/3] tpm: move tpm_eventlog.h outside of drivers folder Thiebaud Weksteen
2017-09-11 10:00 ` [PATCH v2 2/3] efi: call get_event_log before ExitBootServices Thiebaud Weksteen
[not found] ` <20170911100022.7251-3-tweek-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-09-13 14:49 ` kbuild test robot
[not found] ` <201709132252.uZyTCtDz%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-09-13 16:28 ` Thiebaud Weksteen via tpmdd-devel
2017-09-14 10:24 ` [tpmdd-devel] " Javier Martinez Canillas
[not found] ` <1f25ebdc-ab90-517f-b580-991a7cb5e25a-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-09-18 12:11 ` Thiebaud Weksteen
2017-09-18 12:49 ` Javier Martinez Canillas
2017-09-14 18:43 ` Jarkko Sakkinen
[not found] ` <20170914184126.eevnstwq3i6fiq4j-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-14 18:48 ` Matthew Garrett
2017-09-14 19:02 ` Jarkko Sakkinen
[not found] ` <20170914190247.rrbdzdexjjywxipf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-15 4:06 ` Jarkko Sakkinen
2017-09-18 12:28 ` Thiebaud Weksteen
[not found] ` <CA+zpnLfs=DhW6kgbLV63_XzmKS7VnGGE0ecbFBZ0bu4wx3Jf+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-18 17:56 ` Jarkko Sakkinen
2017-09-11 10:00 ` [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Thiebaud Weksteen
[not found] ` <20170911100022.7251-4-tweek-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-09-11 16:47 ` Jason Gunthorpe
2017-09-12 8:48 ` Thiebaud Weksteen
[not found] ` <20170912084851.z3ednbeojawnyxk2-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-09-18 12:38 ` Thiebaud Weksteen
2017-09-18 16:28 ` Jason Gunthorpe
2017-09-13 16:27 ` kbuild test robot
[not found] ` <201709140034.ESdZA8H8%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-09-13 16:43 ` Thiebaud Weksteen
2017-09-14 18:47 ` Jarkko Sakkinen
[not found] ` <20170914184732.uiypaz4yft777oc7-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-18 12:33 ` Thiebaud Weksteen
[not found] ` <20170911100022.7251-1-tweek-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-09-13 18:59 ` [PATCH v2 0/3] Call GetEventLog before ExitBootServices Jarkko Sakkinen
2017-11-03 15:27 ` Jarkko Sakkinen
2017-09-14 10:21 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d530df3-7a7a-4cd7-bde6-92f733c7ae75@redhat.com \
--to=javierm@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mjg59@google.com \
--cc=pjones@redhat.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).