tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: <Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org>
To: benoit.houyere-qxv4g6HH51o@public.gmane.org,
	jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	christophe-h.ricard-qxv4g6HH51o@public.gmane.org
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v3 0/2] tpm_tis_spi: Use DMA-safe memory
Date: Thu, 31 Aug 2017 12:34:33 +0000	[thread overview]
Message-ID: <6b67f719b71e4eb8abd2ba8b3ed57560@MUCSE603.infineon.com> (raw)
In-Reply-To: <fe81962beaec4c6fa21ea90df0f01560-tklXXlf0F76qZDvoWP1BVkEOCMrvLtNR@public.gmane.org>

> Hi Alexander,
> 
> Obviously, we agree to cover validation with STM TPM to confirm your
> update.
> Following my availability, I cannot start it before mid of September. Is it inline
> with your expectation ?

As always, better than nothing, thanks :)

> If it's the case, I will start :
> - tpm_tis_spi on Raspberry PI 3
> Next
> - tpm_tis on X86_64

Those patches only change tpm_tis_spi, so you can skip the tests with tpm_tis.

> Could you send me patch file or link to get patch ?

Unfortunately, Patchwork is not working anymore, so I'll send you the patches in a separate mail.

> By taking Raspberry PI 3 example, How many Byte in SPI transfer size is
> necessary to use DMA transfer ?

The Raspberry Pi 3 uses drivers/spi/spi-bcm2835.c, which defines BCM2835_SPI_DMA_MIN_LENGTH = 96 bytes. The maximum frame size used by tpm_tis_spi is MAX_SPI_FRAMESIZE = 64 bytes, so the DMA code path is never taken. You could try to set BCM2835_SPI_DMA_MIN_LENGTH to a lower value, to force it to use DMA.

> Best Regards,
> 
> Benoit

Alexander
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

  parent reply	other threads:[~2017-08-31 12:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24  8:27 Alexander Steffen
     [not found] ` <20170824082745.9372-1-Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org>
2017-08-24  8:27   ` [PATCH v3 1/2] tpm_tis_spi: Use DMA-safe memory for SPI transfers Alexander Steffen
2017-08-25 16:39     ` Jarkko Sakkinen
2017-08-24  8:27   ` [PATCH v3 2/2] tpm_tis_spi: Use a single buffer " Alexander Steffen
     [not found]     ` <20170824082745.9372-3-Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org>
2017-08-25 16:39       ` Jarkko Sakkinen
2017-08-26 11:22   ` [PATCH v3 0/2] tpm_tis_spi: Use DMA-safe memory Jarkko Sakkinen
     [not found]     ` <20170826112259.ypwtqbwakyfdqkzo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-08-29 12:14       ` Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w
     [not found]         ` <9aea582eccbe4655b5de487dacf7c745-nFblLGNE8XKJSz+rYg/bSJowlv4uC7bZ@public.gmane.org>
2017-08-30  8:42           ` Benoit HOUYERE
     [not found]             ` <fe81962beaec4c6fa21ea90df0f01560-tklXXlf0F76qZDvoWP1BVkEOCMrvLtNR@public.gmane.org>
2017-08-31 12:34               ` Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w [this message]
2017-08-30 10:08           ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b67f719b71e4eb8abd2ba8b3ed57560@MUCSE603.infineon.com \
    --to=alexander.steffen-d0qzbvysippwk0htik3j/w@public.gmane.org \
    --cc=benoit.houyere-qxv4g6HH51o@public.gmane.org \
    --cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --subject='Re: [PATCH v3 0/2] tpm_tis_spi: Use DMA-safe memory' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).