From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH 2/5] Fix "ERROR: code indent should use tabs where possible" Date: Mon, 31 Jul 2017 20:25:03 +1000 Message-ID: <87bmo06gzk.fsf@concordia.ellerman.id.au> References: <20170729072433.13194-1-sz.lin@moxa.com> <20170729072433.13194-3-sz.lin@moxa.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20170729072433.13194-3-sz.lin@moxa.com> Sender: linux-kernel-owner@vger.kernel.org To: ashleydlai@gmail.com Cc: benh@kernel.crashing.org, paulus@samba.org, peterhuewe@gmx.de, tpmdd@selhorst.ne, jarkko.sakkinen@linux.intel.com, jgunthorpe@obsidianresearch.com, tpmdd-devel@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, SZ Lin List-Id: tpmdd-devel@lists.sourceforge.net SZ Lin writes: > ERROR: code indent should use tabs where possible > +^I^I "Need to wait for TPM to finish\n");$ > > Signed-off-by: SZ Lin > --- > drivers/char/tpm/tpm_ibmvtpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c > index f01d083eced2..23913fc86158 100644 > --- a/drivers/char/tpm/tpm_ibmvtpm.c > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > @@ -127,7 +127,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count) > > if (ibmvtpm->tpm_processing_cmd) { > dev_info(ibmvtpm->dev, > - "Need to wait for TPM to finish\n"); > + "Need to wait for TPM to finish\n"); There's no reason for that to be on a separate line at all. Just make it a single line dev_info( ... ); cheers