From: Felipe Balbi <balbi@kernel.org>
To: linux-acpi@vger.kernel.org, tpmdd-devel@lists.sourceforge.net,
intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-input@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-mmc@vger.kernel.org, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, linux-usb@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Borislav Petkov <bp@suse.de>,
Dan Williams <dan.j.williams@intel.com>,
Amir Goldstein <amir73il@gmail.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Ben Skeggs <bskeggs@redhat.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Joerg Roedel <joro@8bytes.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Zhang Rui <rui.zhang@intel.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark
Subject: Re: [PATCH v1] ACPI: Switch to use generic UUID API
Date: Tue, 09 May 2017 10:56:43 +0300 [thread overview]
Message-ID: <87o9v2jwec.fsf@linux.intel.com> (raw)
In-Reply-To: <20170504092151.88646-1-andriy.shevchenko@linux.intel.com>
Hi,
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16
> bytes. Instead we convert them to use uuid_le type. At the same time we
> convert current users.
>
> acpi_str_to_uuid() becomes useless after the conversion and it's safe to
> get rid of it.
>
> The conversion fixes a potential bug in int340x_thermal as well since
> we have to use memcmp() on binary data.
>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Amir Goldstein <amir73il@gmail.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> index a15ec71d0423..6b5284ec76df 100644
> --- a/drivers/usb/dwc3/dwc3-pci.c
> +++ b/drivers/usb/dwc3/dwc3-pci.c
> @@ -56,7 +56,7 @@ struct dwc3_pci {
> struct platform_device *dwc3;
> struct pci_dev *pci;
>
> - u8 uuid[16];
> + uuid_le uuid;
>
> unsigned int has_dsm_for_pm:1;
> };
> @@ -118,7 +118,7 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc)
>
> if (pdev->device == PCI_DEVICE_ID_INTEL_BXT ||
> pdev->device == PCI_DEVICE_ID_INTEL_BXT_M) {
> - acpi_str_to_uuid(PCI_INTEL_BXT_DSM_UUID, dwc->uuid);
> + uuid_le_to_bin(PCI_INTEL_BXT_DSM_UUID, &dwc->uuid);
> dwc->has_dsm_for_pm = true;
> }
>
> @@ -288,7 +288,7 @@ static int dwc3_pci_dsm(struct dwc3_pci *dwc, int param)
> tmp.type = ACPI_TYPE_INTEGER;
> tmp.integer.value = param;
>
> - obj = acpi_evaluate_dsm(ACPI_HANDLE(&dwc->pci->dev), dwc->uuid,
> + obj = acpi_evaluate_dsm(ACPI_HANDLE(&dwc->pci->dev), &dwc->uuid,
> 1, PCI_INTEL_BXT_FUNC_PMU_PWR, &argv4);
> if (!obj) {
> dev_err(&dwc->pci->dev, "failed to evaluate _DSM\n");
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
--
balbi
next prev parent reply other threads:[~2017-05-09 7:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 9:21 [PATCH v1] ACPI: Switch to use generic UUID API Andy Shevchenko
2017-05-04 9:37 ` Jani Nikula
2017-05-04 12:14 ` Heikki Krogerus
2017-05-04 12:46 ` Joerg Roedel
2017-05-04 13:51 ` Bjorn Helgaas
2017-05-04 15:29 ` Benjamin Tissoires
2017-05-05 6:04 ` kbuild test robot
2017-05-05 6:20 ` Dan Williams
2017-05-05 7:06 ` Amir Goldstein
[not found] ` <CAOQ4uxjha8_2_HwgdgBN=G-vNytAW5Gk155E9z8OWyFiGNEZVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-05 7:30 ` Christoph Hellwig
2017-05-05 9:24 ` Andy Shevchenko
2017-05-05 9:50 ` Amir Goldstein
2017-05-05 9:57 ` Christoph Hellwig
2017-05-05 10:02 ` Amir Goldstein
2017-05-09 7:56 ` Felipe Balbi [this message]
2017-05-09 8:22 ` Mathias Nyman
2017-05-10 1:20 ` Zhang Rui
[not found] ` <20170504092151.88646-1-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-05-22 19:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9v2jwec.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amir73il@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=bskeggs@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jani.nikula@linux.intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=joro@8bytes.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).