tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: tpmdd@selhorst.net, linux-kernel@vger.kernel.org,
	jarkko.sakkinen@linux.intel.com,
	tpmdd-devel@lists.sourceforge.net, ashleydlai@gmail.com,
	peterhuewe@gmx.de, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] tpm: vtpm: constify vio_device_id
Date: Fri, 18 Aug 2017 21:32:46 +1000	[thread overview]
Message-ID: <87ziaxp0v5.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20170817191642.GF24735@obsidianresearch.com>

Jason Gunthorpe <jgunthorpe@obsidianresearch.com> writes:

> On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote:
>> vio_device_id are not supposed to change at runtime. All functions
>> working with vio_device_id provided by <asm/vio.h> work with
>> const vio_device_id. So mark the non-const structs as const.
>> 
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Thanks Jason.

>>  drivers/char/tpm/tpm_ibmvtpm.c | 2 +-

Who merges changes for this driver? I assume it's Jarkko?

cheers

  reply	other threads:[~2017-08-18 11:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 17:34 [PATCH] tpm: vtpm: constify vio_device_id Arvind Yadav
2017-08-17 19:16 ` Jason Gunthorpe
2017-08-18 11:32   ` Michael Ellerman [this message]
     [not found]     ` <87ziaxp0v5.fsf-W0DJWXSxmBNbyGPkN3NxC2scP1bn1w/D@public.gmane.org>
2017-08-18 20:31       ` Jason Gunthorpe
2017-08-19 17:21         ` Jarkko Sakkinen
     [not found]           ` <20170819172150.sta6erdmikpfkrgv-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-08-23 14:06             ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ziaxp0v5.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=ashleydlai@gmail.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=peterhuewe@gmx.de \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).