tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net,
	linux-security-module@vger.kernel.org,
	jgunthorpe@obsidianresearch.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] tpm: Refactor tpm_transmit pulling out tpm_transfer function
Date: Mon, 15 May 2017 12:06:57 -0400	[thread overview]
Message-ID: <89842442-e92f-6a65-9998-dd5eb186ca4c@linux.vnet.ibm.com> (raw)
In-Reply-To: <1b9e7995-8ed0-cc62-40b7-55b8d1e71ffe@linux.vnet.ibm.com>

On 05/15/2017 12:04 PM, Stefan Berger wrote:
> On 05/15/2017 08:40 AM, Jarkko Sakkinen wrote:
>> On Wed, May 10, 2017 at 07:54:21PM -0400, Stefan Berger wrote:
>>> Refactor tpm_transmit and pull out code sending the command
>>> and receiving the response and put this into tpm_transfer.
>>>
>>> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>>> ---
>>>   drivers/char/tpm/tpm-interface.c | 121 
>>> +++++++++++++++++++++++----------------
>>>   1 file changed, 73 insertions(+), 48 deletions(-)
>>>
>>> diff --git a/drivers/char/tpm/tpm-interface.c 
>>> b/drivers/char/tpm/tpm-interface.c
>>> index 158c1db..263b6d1 100644
>>> --- a/drivers/char/tpm/tpm-interface.c
>>> +++ b/drivers/char/tpm/tpm-interface.c
>>> @@ -370,67 +370,29 @@ static bool tpm_validate_command(struct 
>>> tpm_chip *chip,
>>>   }
>>>     /**
>>> - * tmp_transmit - Internal kernel interface to transmit TPM commands.
>>> + * tmp_transfer - Send a TPM command to the TPM and receive response
>>>    *
>>>    * @chip: TPM chip to use
>>>    * @buf: TPM command buffer
>>> + * @count: size of the TPM command
>>>    * @bufsiz: length of the TPM command buffer
>>> - * @flags: tpm transmit flags - bitmap
>>>    *
>>>    * Return:
>>> - *     0 when the operation is successful.
>>> + *     >0 when the operation is successful; returns response length
>>>    *     A negative number for system errors (errno).
>>>    */
>>> -ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space,
>>> -             u8 *buf, size_t bufsiz, unsigned int flags)
>>> +ssize_t tpm_transfer(struct tpm_chip *chip, u8 *buf, u32 count, 
>>> size_t bufsiz)
>> Add instead a flag TPM_TRANSMIT_RAW (this name is just a suggestion)
>> that skips "prepare" and "commit" parts. That would save us from a
>> new export.
>>
>> Better way to make it less messy would be to add static functions
>> tpm_prepare_command and tpm_commit_command that would be always
>> called and would return immediately if flags contain TPM_TRANSMIT_RAW.
>
> I'll do that then, modifying the code to skip tpm_validate_command as 
> well.
>

But we don't want to recurse (in the 2nd patch) into 
chip->ops->request_locality(). Any suggestions ?

    Stefan


  reply	other threads:[~2017-05-15 16:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 23:54 [PATCH v4 0/2] Extend the vTPM proxy driver to pass locality Stefan Berger
2017-05-10 23:54 ` [PATCH v4 1/2] tpm: Refactor tpm_transmit pulling out tpm_transfer function Stefan Berger
2017-05-12 13:30   ` Stefan Berger
2017-05-15 12:40   ` Jarkko Sakkinen
2017-05-15 16:04     ` Stefan Berger
2017-05-15 16:06       ` Stefan Berger [this message]
     [not found] ` <1494460462-29022-1-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-10 23:54   ` [PATCH v4 2/2] tpm: vtpm_proxy: Implement request_locality function Stefan Berger
2017-05-15 12:41     ` Jarkko Sakkinen
2017-05-15 15:56       ` Stefan Berger
2017-05-20 12:47         ` Jarkko Sakkinen
2017-05-21 23:52           ` Stefan Berger
2017-05-24 19:25             ` Jarkko Sakkinen
2017-05-16 19:03     ` [tpmdd-devel] " Ken Goldman
2017-05-16 19:32       ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89842442-e92f-6a65-9998-dd5eb186ca4c@linux.vnet.ibm.com \
    --to=stefanb@linux.vnet.ibm.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).