* [PATCH] tpm: fix duplicate inline declaration specifier
@ 2017-09-26 13:58 Ruben Roy
2017-09-29 17:17 ` Jarkko Sakkinen
0 siblings, 1 reply; 5+ messages in thread
From: Ruben Roy @ 2017-09-26 13:58 UTC (permalink / raw)
To: Peter Huewe, Marcel Selhorst, Jarkko Sakkinen, Jason Gunthorpe,
tpmdd-devel, linux-kernel
Cc: Nick Desaulniers, trivial, Ruben Roy
This commit fixes the duplicate inline declaration specifier in
tpm2_rc_value which caused a warning
Signed-off-by: Ruben Roy <rubenroy2005@gmail.com>
---
drivers/char/tpm/tpm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
index 04fbff2..f4d0272 100644
--- a/drivers/char/tpm/tpm.h
+++ b/drivers/char/tpm/tpm.h
@@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
}
#endif
-static inline inline u32 tpm2_rc_value(u32 rc)
+static inline u32 tpm2_rc_value(u32 rc)
{
return (rc & BIT(7)) ? rc & 0xff : rc;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] tpm: fix duplicate inline declaration specifier
2017-09-26 13:58 [PATCH] tpm: fix duplicate inline declaration specifier Ruben Roy
@ 2017-09-29 17:17 ` Jarkko Sakkinen
2017-09-30 0:46 ` Nick Desaulniers
2017-10-04 11:31 ` Jarkko Sakkinen
0 siblings, 2 replies; 5+ messages in thread
From: Jarkko Sakkinen @ 2017-09-29 17:17 UTC (permalink / raw)
To: Ruben Roy
Cc: Peter Huewe, Marcel Selhorst, Jason Gunthorpe, tpmdd-devel,
linux-kernel, Nick Desaulniers, trivial
On Tue, Sep 26, 2017 at 01:58:57PM +0000, Ruben Roy wrote:
> This commit fixes the duplicate inline declaration specifier in
> tpm2_rc_value which caused a warning
>
> Signed-off-by: Ruben Roy <rubenroy2005@gmail.com>
> ---
> drivers/char/tpm/tpm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> index 04fbff2..f4d0272 100644
> --- a/drivers/char/tpm/tpm.h
> +++ b/drivers/char/tpm/tpm.h
> @@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
> }
> #endif
>
> -static inline inline u32 tpm2_rc_value(u32 rc)
> +static inline u32 tpm2_rc_value(u32 rc)
> {
> return (rc & BIT(7)) ? rc & 0xff : rc;
> }
> --
> 1.8.3.1
>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] tpm: fix duplicate inline declaration specifier
2017-09-29 17:17 ` Jarkko Sakkinen
@ 2017-09-30 0:46 ` Nick Desaulniers
2017-10-04 11:31 ` Jarkko Sakkinen
1 sibling, 0 replies; 5+ messages in thread
From: Nick Desaulniers @ 2017-09-30 0:46 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Ruben Roy, Peter Huewe, Marcel Selhorst, Jason Gunthorpe,
tpmdd-devel, linux-kernel, trivial
Thanks! This fixes a warning I was seeing with Clang:
drivers/char/tpm/tpm.h:560:15: warning: duplicate 'inline' declaration
specifier [-Wduplicate-decl-specifier]
On Fri, Sep 29, 2017 at 10:17 AM, Jarkko Sakkinen
<jarkko.sakkinen@linux.intel.com> wrote:
> On Tue, Sep 26, 2017 at 01:58:57PM +0000, Ruben Roy wrote:
>> This commit fixes the duplicate inline declaration specifier in
>> tpm2_rc_value which caused a warning
>>
>> Signed-off-by: Ruben Roy <rubenroy2005@gmail.com>
>> ---
>> drivers/char/tpm/tpm.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
>> index 04fbff2..f4d0272 100644
>> --- a/drivers/char/tpm/tpm.h
>> +++ b/drivers/char/tpm/tpm.h
>> @@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
>> }
>> #endif
>>
>> -static inline inline u32 tpm2_rc_value(u32 rc)
>> +static inline u32 tpm2_rc_value(u32 rc)
>> {
>> return (rc & BIT(7)) ? rc & 0xff : rc;
>> }
>> --
>> 1.8.3.1
>>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> /Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] tpm: fix duplicate inline declaration specifier
2017-09-29 17:17 ` Jarkko Sakkinen
2017-09-30 0:46 ` Nick Desaulniers
@ 2017-10-04 11:31 ` Jarkko Sakkinen
[not found] ` <20171004113112.u5jnf3ims7vcxo7b-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
1 sibling, 1 reply; 5+ messages in thread
From: Jarkko Sakkinen @ 2017-10-04 11:31 UTC (permalink / raw)
To: Ruben Roy
Cc: Peter Huewe, Marcel Selhorst, Jason Gunthorpe, tpmdd-devel,
linux-kernel, Nick Desaulniers, trivial
On Fri, Sep 29, 2017 at 08:17:04PM +0300, Jarkko Sakkinen wrote:
> On Tue, Sep 26, 2017 at 01:58:57PM +0000, Ruben Roy wrote:
> > This commit fixes the duplicate inline declaration specifier in
> > tpm2_rc_value which caused a warning
> >
> > Signed-off-by: Ruben Roy <rubenroy2005@gmail.com>
> > ---
> > drivers/char/tpm/tpm.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> > index 04fbff2..f4d0272 100644
> > --- a/drivers/char/tpm/tpm.h
> > +++ b/drivers/char/tpm/tpm.h
> > @@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
> > }
> > #endif
> >
> > -static inline inline u32 tpm2_rc_value(u32 rc)
> > +static inline u32 tpm2_rc_value(u32 rc)
> > {
> > return (rc & BIT(7)) ? rc & 0xff : rc;
> > }
> > --
> > 1.8.3.1
> >
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> /Jarkko
Applied.
/Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-04 11:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-26 13:58 [PATCH] tpm: fix duplicate inline declaration specifier Ruben Roy
2017-09-29 17:17 ` Jarkko Sakkinen
2017-09-30 0:46 ` Nick Desaulniers
2017-10-04 11:31 ` Jarkko Sakkinen
[not found] ` <20171004113112.u5jnf3ims7vcxo7b-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-04 11:34 ` Ruben Roy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).