archive mirror
 help / color / mirror / Atom feed
From: Josh Zimmerman <>
To: Jason Gunthorpe
Cc: Greg Kroah-Hartman
Subject: Re: [PATCH v2] tpm: Issue a TPM2_Shutdown for TPM2 devices.
Date: Mon, 15 May 2017 17:24:53 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20170515174053.GA6229-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/>

Resending to all recipients...
On Mon, May 15, 2017 at 10:40 AM, Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/> wrote:
> On Mon, May 15, 2017 at 10:33:04AM -0700, Josh Zimmerman wrote:
>> +     if (chip->flags & TPM_CHIP_FLAG_TPM2) {
>> +             down_write(&chip->ops_sem);
>> +             tpm2_shutdown(chip, TPM_SU_CLEAR);
> Would it be appropriate to now chain to the device_driver shutdown
> in case any TPM-bus related shutdown is required?
> We don't have any drivers that need that today though.

I think I'd prefer to keep the patch to the functionality we need
today. Is there any reason to prefer adding this functionality now
rather than waiting for a specific driver that needs it to add it when
it comes up?

Check out the vibrant tech community on one of the world's most
engaging tech sites,!

  parent reply	other threads:[~2017-05-16  0:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 17:33 [PATCH v2] tpm: Issue a TPM2_Shutdown for TPM2 devices Josh Zimmerman
     [not found] ` <>
2017-05-15 17:40   ` Jason Gunthorpe
     [not found]     ` <20170515174053.GA6229-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/>
2017-05-16  0:24       ` Josh Zimmerman [this message]
2017-05-20 12:44   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).