From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Zimmerman Subject: Re: [PATCH v2] tpm: Issue a TPM2_Shutdown for TPM2 devices. Date: Mon, 15 May 2017 17:24:53 -0700 Message-ID: References: <20170515173304.12216-1-joshz@google.com> <20170515174053.GA6229@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170515174053.GA6229-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: Greg Kroah-Hartman , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net Resending to all recipients... On Mon, May 15, 2017 at 10:40 AM, Jason Gunthorpe wrote: > On Mon, May 15, 2017 at 10:33:04AM -0700, Josh Zimmerman wrote: >> + if (chip->flags & TPM_CHIP_FLAG_TPM2) { >> + down_write(&chip->ops_sem); >> + tpm2_shutdown(chip, TPM_SU_CLEAR); > > Would it be appropriate to now chain to the device_driver shutdown > in case any TPM-bus related shutdown is required? > > We don't have any drivers that need that today though. I think I'd prefer to keep the patch to the functionality we need today. Is there any reason to prefer adding this functionality now rather than waiting for a specific driver that needs it to add it when it comes up? ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot