From: Josh Zimmerman <firstname.lastname@example.org>
To: Greg KH <email@example.com>
Cc: Jarkko Sakkinen <firstname.lastname@example.org>,
Jason Gunthorpe <email@example.com>,
Subject: Re: [PATCH v1 4/4] tpm: Issue a TPM2_Shutdown for TPM2 devices.
Date: Tue, 18 Jul 2017 09:11:49 -0700 [thread overview]
Message-ID: <CAHSjozBE-=aCZoBvuHanPWYQKhY3Lj5YTNnnA65Q-GgZ2y1iSQ@mail.gmail.com> (raw)
On Tue, Jul 18, 2017 at 8:49 AM, Greg KH <firstname.lastname@example.org> wrote:
> On Fri, Jul 14, 2017 at 12:58:03PM -0700, Josh Zimmerman wrote:
>> Backport of d1bd4a792d3961a04e6154118816b00167aad91a upstream.
>> If a TPM2 loses power without a TPM2_Shutdown command being issued (a
>> "disorderly reboot"), it may lose some state that has yet to be
>> persisted to NVRam, and will increment the DA counter. After the DA
>> counter gets sufficiently large, the TPM will lock the user out.
>> NOTE: This only changes behavior on TPM2 devices. Since TPM1 uses sysfs,
>> and sysfs relies on implicit locking on chip->ops, it is not safe to
>> allow this code to run in TPM1, or to add sysfs support to TPM2, until
>> that locking is made explicit.
>> drivers/char/tpm/tpm-chip.c | 36 ++++++++++++++++++++++++++++++++++++
>> drivers/char/tpm/tpm-sysfs.c | 7 +++++++
>> 2 files changed, 43 insertions(+)
> Again no signed-off-by :(
Oops, sorry about that.
Did you pull in the two cherry-picks as well? They're needed for these
two to build and merge cleanly.
I can send a v2 if you need with a corrected signed-off-by and correct
number of patches in the cover letter.
next prev parent reply other threads:[~2017-07-18 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 19:57 [PATCH v1 0/2] Run TPM2_Shutdown on system shutdown Josh Zimmerman
2017-07-14 19:58 ` [PATCH v1 1/4] tpm: Get rid of chip->pdev Josh Zimmerman
2017-07-14 19:58 ` [PATCH v1 2/4] tpm: Provide strong locking for device removal Josh Zimmerman
2017-07-14 19:58 ` [PATCH v1 3/4] Add "shutdown" to "struct class".' Josh Zimmerman
2017-07-18 15:48 ` Greg KH
2017-07-14 19:58 ` [PATCH v1 4/4] tpm: Issue a TPM2_Shutdown for TPM2 devices Josh Zimmerman
2017-07-18 15:49 ` Greg KH
2017-07-18 16:11 ` Josh Zimmerman [this message]
2017-07-18 16:29 ` Greg KH
2017-07-18 16:33 ` Josh Zimmerman
2017-07-18 15:50 ` [PATCH v1 0/2] Run TPM2_Shutdown on system shutdown Greg KH
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).