From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amir Goldstein Subject: Re: [PATCH v1] ACPI: Switch to use generic UUID API Date: Fri, 5 May 2017 13:02:21 +0300 Message-ID: References: <20170504092151.88646-1-andriy.shevchenko@linux.intel.com> <1493976265.30052.21.camel@linux.intel.com> <20170505095739.GB6762@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20170505095739.GB6762@lst.de> Sender: linux-pci-owner@vger.kernel.org To: Christoph Hellwig Cc: Andy Shevchenko , Dan Williams , Linux ACPI , tpmdd-devel@lists.sourceforge.net, intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-input@vger.kernel.org, iommu@lists.linux-foundation.org, linux-mmc@vger.kernel.org, Netdev , linux-pci@vger.kernel.org, USB list , alsa-devel@alsa-project.org, "linux-kernel@vger.kernel.org" , "Rafael J . Wysocki" , Mika Westerberg , Borislav Petkov , Jarkko Sakkinen , Jani Nikula , Ben Skeggs , Benj List-Id: tpmdd-devel@lists.sourceforge.net On Fri, May 5, 2017 at 12:57 PM, Christoph Hellwig wrote: > On Fri, May 05, 2017 at 12:50:31PM +0300, Amir Goldstein wrote: >> To complete the picture for folks not cc'ed on my patches, >> xfs use case suggests there is also justification for the additional helpers: >> >> uuid_is_null() / uuid_equal() >> guid_is_null() / guid_equal() > > The is_null is useful and I bet we'll find other instances. I'm > not sure _equals really adds much value over the existing _cmp > helpers, but on the other hand they are so trivial that we might as > well add them. Exactly. The fact that not only xfs used the same helper name (drivers/md/md.c) suggests that it useful. > > The other thing XFS has is uuid_copy. Andy already listed uuid_copy.